[GH-ISSUE #443] Bug: workbook_add_worksheet does not return a reasonable worksheet #346

New issue

Closed

opened 2026-05-05 12:11:10 -06:00 by gitea-mirror · 1 comment

gitea-mirror commented

2026-05-05 12:11:10 -06:00

Owner

Originally created by @ym-xie on GitHub (May 8, 2024).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/443

Originally assigned to: @jmcnamara on GitHub.

There may be a semantic bug here. When name is NULL, but the same name has been written before, a worksheet with a new valid name should be returned.

#include "xlsxwriter.h"
int main() {
    lxw_workbook  *workbook  = workbook_new("demo.xlsx");
    const char* name[] = {"Sheet1", "Sheet2", "Sheet4", NULL};
    for (int i = 0; i < sizeof(name) / sizeof(*name); ++i) {
      if (name[i] == NULL || workbook_validate_sheet_name(workbook, name[i]) == LXW_NO_ERROR) {
        lxw_worksheet *worksheet = workbook_add_worksheet(workbook, name[i]);
        if (worksheet == NULL) {
          __builtin_trap();
        }
      }
    }
    return 0;
}

Originally created by @ym-xie on GitHub (May 8, 2024). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/443 Originally assigned to: @jmcnamara on GitHub. There may be a semantic bug here. When name is NULL, but the same name has been written before, a worksheet with a new valid name should be returned. ```c #include "xlsxwriter.h" int main() { lxw_workbook *workbook = workbook_new("demo.xlsx"); const char* name[] = {"Sheet1", "Sheet2", "Sheet4", NULL}; for (int i = 0; i < sizeof(name) / sizeof(*name); ++i) { if (name[i] == NULL || workbook_validate_sheet_name(workbook, name[i]) == LXW_NO_ERROR) { lxw_worksheet *worksheet = workbook_add_worksheet(workbook, name[i]); if (worksheet == NULL) { __builtin_trap(); } } } return 0; } ```

gitea-mirror closed this issue

2026-05-05 12:11:11 -06:00

gitea-mirror commented

2026-05-05 12:11:14 -06:00

Author

Owner

@jmcnamara commented on GitHub (May 8, 2024):

For me this isn't a bug. The default sheet naming is intended to be simple and incremental. If the user has a scenario where they want to use one of the default names out of sequence then they should avoid using default naming or at least add some logic to avoid this issue.

Closing as won't fix.

@jmcnamara commented on GitHub (May 8, 2024): For me this isn't a bug. The default sheet naming is intended to be simple and incremental. If the user has a scenario where they want to use one of the default names out of sequence then they should avoid using default naming or at least add some logic to avoid this issue. Closing as won't fix.