[GH-ISSUE #366] Weakness in Set header and footer that can lead to crash #290

New issue

Closed

opened 2026-05-05 12:06:24 -06:00 by gitea-mirror · 5 comments

gitea-mirror commented

2026-05-05 12:06:24 -06:00

Owner

Originally created by @gabrielaexile on GitHub (Feb 22, 2022).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/366

Originally assigned to: @jmcnamara on GitHub.

Hello

Setting header or footer generates error then it will call free(self->footer); in various of places. But it will not set it to NULL, which will cause problem when you come to lxw_worksheet_free where it will again free the footer and header which now are invalid pointers.

Originally created by @gabrielaexile on GitHub (Feb 22, 2022). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/366 Originally assigned to: @jmcnamara on GitHub. Hello Setting header or footer generates error then it will call **free(self->footer);** in various of places. But it will not set it to NULL, which will cause problem when you come to lxw_worksheet_free where it will again free the footer and header which now are invalid pointers.

gitea-mirror

2026-05-05 12:06:24 -06:00

closed this issue
added the
bug

under investigation
labels

gitea-mirror commented

2026-05-05 12:06:30 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 22, 2022):

Thanks, that looks like a bug. I'll look into it.

@jmcnamara commented on GitHub (Feb 22, 2022): Thanks, that looks like a bug. I'll look into it.

gitea-mirror commented

2026-05-05 12:06:31 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 22, 2022):

I've pushed a fix for this to main if you care to try it out.

There is a failing Windows compilation test but I don't think that it is related. I am debugging it.

@jmcnamara commented on GitHub (Feb 22, 2022): I've pushed a fix for this to main if you care to try it out. There is a failing Windows compilation test but I don't think that it is related. I am debugging it.

gitea-mirror commented

2026-05-05 12:06:32 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 23, 2022):

The failing test is related so I'll need to look at this a bit more.

@jmcnamara commented on GitHub (Feb 23, 2022): The failing test is related so I'll need to look at this a bit more.

gitea-mirror commented

2026-05-05 12:06:34 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 23, 2022):

I fixed the Windows issue, it was in the test case and not the code. I also did a bit more refactoring to take care of some other edge cases in the header/footer failure modes.

Anyway, let me know if this resolves your issue. I will close the GitHub issue in a few days if there is no update.

@jmcnamara commented on GitHub (Feb 23, 2022): I fixed the Windows issue, it was in the test case and not the code. I also did a bit more refactoring to take care of some other edge cases in the header/footer failure modes. Anyway, let me know if this resolves your issue. I will close the GitHub issue in a few days if there is no update.

gitea-mirror commented

2026-05-05 12:06:36 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 25, 2022):

Closing. If there are any further issues let me know.

@jmcnamara commented on GitHub (Feb 25, 2022): Closing. If there are any further issues let me know.