[GH-ISSUE #300] Please don't use field name "delete". #240

New issue

Closed

opened 2026-05-05 12:00:56 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 12:00:56 -06:00

Owner

Originally created by @toge on GitHub (Aug 4, 2020).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/300

Originally assigned to: @jmcnamara on GitHub.

"delete" is C++ reserved word.
So C++ compiler can't compile 0.9.6.

include/xlsxwriter/chart.h:815:13: error: expected unqualified-id before ‘delete’
  815 |     uint8_t delete;
      |             ^~~~~~

Originally created by @toge on GitHub (Aug 4, 2020). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/300 Originally assigned to: @jmcnamara on GitHub. "delete" is C++ reserved word. So C++ compiler can't compile 0.9.6. ``` include/xlsxwriter/chart.h:815:13: error: expected unqualified-id before ‘delete’ 815 | uint8_t delete; | ^~~~~~ ```

gitea-mirror

2026-05-05 12:00:56 -06:00

closed this issue
added the
bug

in progress
labels

gitea-mirror commented

2026-05-05 12:01:02 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 4, 2020):

Ouch. That shows how long it has been since I've written any C++ and also why Doxygen has colorising that word. :-(

I'll change it to hide or similar.

I should also add a C++ compilation test. I usually don't bother due to all the alloc warnings/errors.

Anyone have any suggestions on how to add a C++ compilation that will catch errors?

@jmcnamara commented on GitHub (Aug 4, 2020): Ouch. That shows how long it has been since I've written any C++ and also why Doxygen has colorising that word. :-( I'll change it to `hide` or similar. I should also add a C++ compilation test. I usually don't bother due to all the alloc warnings/errors. Anyone have any suggestions on how to add a C++ compilation that will catch errors?

gitea-mirror commented

2026-05-05 12:01:04 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 4, 2020):

Fixed in version 0.9.7.

Let me know how you are compiling this with C++ so I can try avoid issues like this in future. Thanks.

@jmcnamara commented on GitHub (Aug 4, 2020): Fixed in version 0.9.7. Let me know how you are compiling this with C++ so I can try avoid issues like this in future. Thanks.

gitea-mirror commented

2026-05-05 12:01:06 -06:00

Author

Owner

@toge commented on GitHub (Aug 4, 2020):

Thank you for your quick response!
Now I can compile 0.9.7, and every code work fine!

I usually compile C++ code with g++ -std=c++17 -Wall -Wextra -pedantic.
g++ 10.2.0 can work fine with your library without any warning messages.

@toge commented on GitHub (Aug 4, 2020): Thank you for your quick response! Now I can compile 0.9.7, and every code work fine! I usually compile C++ code with `g++ -std=c++17 -Wall -Wextra -pedantic`. g++ 10.2.0 can work fine with your library without any warning messages.

gitea-mirror commented

2026-05-05 12:01:08 -06:00

Author

Owner

@jmcnamara commented on GitHub (Aug 4, 2020):

I usually compile C++ code with g++ -std=c++17 -Wall -Wextra -pedantic.

How exactly are you compiling. I can't get minizip to compile with those options. If I compile minizip separately I can compile everything else, but with a lot of warnings:

$ CFLAGS="-std=c++17 -Wall -Wextra -pedantic -fpermissive" make V=1 CC=g++-9

@jmcnamara commented on GitHub (Aug 4, 2020): > I usually compile C++ code with `g++ -std=c++17 -Wall -Wextra -pedantic`. How exactly are you compiling. I can't get minizip to compile with those options. If I compile minizip separately I can compile everything else, but with a lot of warnings: ``` $ CFLAGS="-std=c++17 -Wall -Wextra -pedantic -fpermissive" make V=1 CC=g++-9 ```