github-starred/libxlsxwriter

Fork 0

mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00

[GH-ISSUE #295] Height DPI is incorrectly set to width DPI for PNG and JPEG images #237

New issue

Closed

opened 2026-05-05 12:00:47 -06:00 by gitea-mirror · 4 comments

gitea-mirror commented

2026-05-05 12:00:47 -06:00

Owner

Originally created by @evanmiller on GitHub (Jun 8, 2020).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/295

Originally assigned to: @jmcnamara on GitHub.

There are bugs in these two lines:

a0d920e589/src/worksheet.c (L2825)
a0d920e589/src/worksheet.c (L2951)

They should read:

object_props->y_dpi = y_dpi ? y_dpi : 96;

image_props->y_dpi = y_dpi ? y_dpi : 96;

Originally created by @evanmiller on GitHub (Jun 8, 2020). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/295 Originally assigned to: @jmcnamara on GitHub. There are bugs in these two lines: https://github.com/jmcnamara/libxlsxwriter/blob/a0d920e589b00b264b37ca3c7b7cefa547721a46/src/worksheet.c#L2825 https://github.com/jmcnamara/libxlsxwriter/blob/a0d920e589b00b264b37ca3c7b7cefa547721a46/src/worksheet.c#L2951 They should read: ```C object_props->y_dpi = y_dpi ? y_dpi : 96; ``` ```C image_props->y_dpi = y_dpi ? y_dpi : 96; ```

gitea-mirror

2026-05-05 12:00:47 -06:00

closed this issue
added the
bug

short term
labels

gitea-mirror commented

2026-05-05 12:00:51 -06:00

Author

Owner

@jmcnamara commented on GitHub (Jun 8, 2020):

Yikes. Thanks, I'll fix those.

Btw, do you have an image with different X and Y dpi that shows this issue.

I can probably create one but if you have one already that I can use in a test case could you upload it to save time.

@jmcnamara commented on GitHub (Jun 8, 2020): Yikes. Thanks, I'll fix those. Btw, do you have an image with different X and Y dpi that shows this issue. I can probably create one but if you have one already that I can use in a test case could you upload it to save time.

gitea-mirror commented

2026-05-05 12:00:53 -06:00

Author

Owner

@evanmiller commented on GitHub (Jun 8, 2020):

I do not have a test file. I discovered this while trying to debug some images being inserted with incorrect aspect ratios - possibly related to #284.

@evanmiller commented on GitHub (Jun 8, 2020): I do not have a test file. I discovered this while trying to debug some images being inserted with incorrect aspect ratios - possibly related to #284.

gitea-mirror commented

2026-05-05 12:00:54 -06:00

Author

Owner

@jmcnamara commented on GitHub (Jun 8, 2020):

This isn't related to #284.

No problem. I'll try come up a test case for it.

@jmcnamara commented on GitHub (Jun 8, 2020): This isn't related to #284. No problem. I'll try come up a test case for it.

gitea-mirror commented

2026-05-05 12:00:55 -06:00

Author

Owner

@jmcnamara commented on GitHub (Jul 30, 2020):

Fixed on master. Thanks.

@jmcnamara commented on GitHub (Jul 30, 2020): Fixed on master. Thanks.

gitea-mirror referenced this issue

2026-05-05 12:16:07 -06:00

[PR #239] [MERGED] CMake: Removed debug statement #445

gitea-mirror referenced this issue

2026-05-05 12:16:07 -06:00