[GH-ISSUE #269] Add option USE_DOUBLE_FUNCTION to CMakeLists #214

Closed
opened 2026-05-05 11:57:11 -06:00 by gitea-mirror · 2 comments
Owner

Originally created by @petricf on GitHub (Jan 20, 2020).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/269

For non-US locales the option -DUSE_DOUBLE_FUNCTION must be passed to the make call to create valid excel files.

This patch allows to pass this option at cmake execution. This let cmake also execute the make step for non-US locales. It saves an extra execution step.

It can be found at gentoo bugtracker:
https://bugs.gentoo.org/attachment.cgi?id=603408&action=edit

The patch was created by Jon Hood.

Please apply this patch.

Originally created by @petricf on GitHub (Jan 20, 2020). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/269 For non-US locales the option -DUSE_DOUBLE_FUNCTION must be passed to the make call to create valid excel files. This patch allows to pass this option at cmake execution. This let cmake also execute the make step for non-US locales. It saves an extra execution step. It can be found at gentoo bugtracker: [https://bugs.gentoo.org/attachment.cgi?id=603408&action=edit](https://bugs.gentoo.org/attachment.cgi?id=603408&action=edit) The patch was created by Jon Hood. Please apply this patch.
gitea-mirror 2026-05-05 11:57:11 -06:00
Author
Owner

@jmcnamara commented on GitHub (Jan 20, 2020):

Thanks. I'll add that and probably make it the default.

<!-- gh-comment-id:576188780 --> @jmcnamara commented on GitHub (Jan 20, 2020): Thanks. I'll add that and probably make it the default.
Author
Owner

@jmcnamara commented on GitHub (Jun 27, 2021):

Added to main. This will be in the next release of libxlsxwriter.

<!-- gh-comment-id:869228815 --> @jmcnamara commented on GitHub (Jun 27, 2021): Added to main. This will be in the next release of libxlsxwriter.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/libxlsxwriter#214
No description provided.