mirror of
https://github.com/jmcnamara/libxlsxwriter.git
synced 2026-05-15 14:15:54 -06:00
[GH-ISSUE #243] ZLIB_ROOT ingored warning #194
Labels
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/libxlsxwriter#194
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @John-Colvin on GitHub (Aug 30, 2019).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/243
Originally assigned to: @jmcnamara on GitHub.
I'm guessing you should set the policy in
CmakeLists.txt, but I don't really know cmake@jmcnamara commented on GitHub (Aug 30, 2019):
I think this may be a duplicate of #242 Can you check, and if it is, add your comments/analysis over there and I'll try to reply in one place.
@John-Colvin commented on GitHub (Aug 30, 2019):
I don't think so, but it's possible if this was fixed it would fix #242
Someone with more knowledge about cmake would probably know better.
@evanmiller commented on GitHub (Aug 31, 2019):
@John-Colvin What version of CMake are you using?
@Alexhuszagh commented on GitHub (Sep 3, 2019):
@evanmiller This is actually an issue with new CMake versions. Confirmed as of Cmake
3.14.5, the error makes it clear this has been an issue since CMake3.12.@Alexhuszagh commented on GitHub (Sep 3, 2019):
@John-Colvin Let me know if the following PR works for you:
https://github.com/jmcnamara/libxlsxwriter/pull/246
@jmcnamara commented on GitHub (Sep 5, 2019):
@John-Colvin Can you test the proposed fix.
@Alexhuszagh commented on GitHub (Sep 8, 2019):
@jmcnamara I'm very certain this should patch the issue, and at the very least, it will patch a similar issue due to CMake introducing a backward compatibility issue, so it might be preferable to commit any changes if there's no reply.
@jmcnamara commented on GitHub (Sep 8, 2019):
@Alexhuszagh Agreed. Fix is merged.
@John-Colvin I'm closing this issue. You can test against the current master to see if your issues is fixed. If it isn't then open a new issue, with details on how to reproduce, or post a follow-up here.