mirror of
https://github.com/jmcnamara/libxlsxwriter.git
synced 2026-05-15 14:15:54 -06:00
[GH-ISSUE #175] Install step fails for release build on windows #144
Labels
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/libxlsxwriter#144
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dirkvdb on GitHub (May 15, 2018).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/175
Originally assigned to: @jmcnamara on GitHub.
When building a release build on windows using the jom makefile generator, the install step fails as it tries to copy the pdb which was not build.
My configure command
@jmcnamara commented on GitHub (May 15, 2018):
Hi,
Could you give the steps to reproduce this (all the steps) and the error/warning when you run the command.
Thanks,
John
@dirkvdb commented on GitHub (May 15, 2018):
reproduction steps:
output:
@jmcnamara commented on GitHub (May 15, 2018):
Thanks. I can reproduce it.
It looks like an issue in the CMakeList.txt around the copying/moving of the libxlsxwriter.pdb file around here: https://github.com/jmcnamara/libxlsxwriter/blob/master/CMakeLists.txt#L219
@Alexhuszagh can you have a look at this.
@dirkvdb in the meantime, while we work on a fix, that error is mainly harmless. the lib file should still be built and you can copy the pdb file manually if you need it.
@jmcnamara commented on GitHub (May 22, 2018):
@Alexhuszagh Gentle reminder if you can look at this. Or @dirkvdb if you know how to fix this and want to submit a PR then that would be appreciated.
@Alexhuszagh commented on GitHub (May 22, 2018):
@jmcnamara Sorry I missed this, I will look at it.
@Alexhuszagh commented on GitHub (Jun 19, 2018):
Sorry should be fixing this today. Sorry for the delay.
@jmcnamara commented on GitHub (Jul 18, 2018):
Confirmed fixed on master. Thanks.