mirror of
https://github.com/jmcnamara/libxlsxwriter.git
synced 2026-05-15 14:15:54 -06:00
[GH-ISSUE #153] CMake: doesn't enforce a unicode build for MSVC #124
Labels
No labels
awaiting user feedback
bug
cmake
cmake
docs
feature request
in progress
long term
medium term
medium term
pull-request
question
question
ready to close
short term
under investigation
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/libxlsxwriter#124
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @RalfKubis on GitHub (Mar 14, 2018).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/153
Originally assigned to: @jmcnamara on GitHub.
Apparently the library requires to be build with the symbol
_UNICODEbeing defined.Otherwise one gets defects like described in #104 and #148 or similar.
A potential fix would be to define this symbol in CMakeLists.txt.
@jmcnamara commented on GitHub (Mar 14, 2018):
I made an attempt to try implement this via commandline switches to cmake. Unsuccessfully.
@Alexhuszagh Could you have a look at implementing this. It is catching a lot of Windows users using cmake.
@RalfKubis commented on GitHub (Mar 14, 2018):
I'm on it. Just preparing a pull-request.