[GH-ISSUE #153] CMake: doesn't enforce a unicode build for MSVC #124

Closed
opened 2026-05-05 11:43:58 -06:00 by gitea-mirror · 2 comments
Owner

Originally created by @RalfKubis on GitHub (Mar 14, 2018).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/153

Originally assigned to: @jmcnamara on GitHub.

Apparently the library requires to be build with the symbol _UNICODE being defined.
Otherwise one gets defects like described in #104 and #148 or similar.

A potential fix would be to define this symbol in CMakeLists.txt.

Originally created by @RalfKubis on GitHub (Mar 14, 2018). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/153 Originally assigned to: @jmcnamara on GitHub. Apparently the library requires to be build with the symbol `_UNICODE` being defined. Otherwise one gets defects like described in #104 and #148 or similar. A potential fix would be to define this symbol in CMakeLists.txt.
gitea-mirror 2026-05-05 11:43:58 -06:00
Author
Owner

@jmcnamara commented on GitHub (Mar 14, 2018):

I made an attempt to try implement this via commandline switches to cmake. Unsuccessfully.

@Alexhuszagh Could you have a look at implementing this. It is catching a lot of Windows users using cmake.

<!-- gh-comment-id:373017166 --> @jmcnamara commented on GitHub (Mar 14, 2018): I made an attempt to try implement this via commandline switches to cmake. Unsuccessfully. @Alexhuszagh Could you have a look at implementing this. It is catching a lot of Windows users using cmake.
Author
Owner

@RalfKubis commented on GitHub (Mar 14, 2018):

I'm on it. Just preparing a pull-request.

<!-- gh-comment-id:373038235 --> @RalfKubis commented on GitHub (Mar 14, 2018): I'm on it. Just preparing a pull-request.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/libxlsxwriter#124
No description provided.