github-starred/libxlsxwriter

Fork 0

mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00

[GH-ISSUE #145] Lib trying to free image memory without image defined #118

New issue

Closed

opened 2026-05-05 11:42:44 -06:00 by gitea-mirror · 7 comments

gitea-mirror commented

2026-05-05 11:42:44 -06:00

Owner

Originally created by @ncfernan on GitHub (Jan 26, 2018).
Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/145

Originally assigned to: @jmcnamara on GitHub.

When using the function worksheet_insert_chart_opt the options parameters is copied to an internal structure that is shared with image functions, so when the program closes the workbook, the image points to dirty areas because no image was set.

If the options parameter is set to NULL, no problem arises.

lxw_image_options options;

options.x_offset = 0;
options.y_offset = 0;
options.x_scale  = 4.0;
options.y_scale  = 1.2;

worksheet_insert_chart_opt (worksheet, 1, col, chart, &options);

Originally created by @ncfernan on GitHub (Jan 26, 2018). Original GitHub issue: https://github.com/jmcnamara/libxlsxwriter/issues/145 Originally assigned to: @jmcnamara on GitHub. When using the function **worksheet_insert_chart_opt** the options parameters is copied to an internal structure that is shared with image functions, so when the program closes the workbook, the **image** points to dirty areas because no image was set. If the **options** parameter is set to NULL, no problem arises. ``` lxw_image_options options; options.x_offset = 0; options.y_offset = 0; options.x_scale = 4.0; options.y_scale = 1.2; worksheet_insert_chart_opt (worksheet, 1, col, chart, &options); ``` ![image](https://user-images.githubusercontent.com/10008844/35452435-9dffdaf2-02ad-11e8-896b-3419b4edc2d0.png)

gitea-mirror

2026-05-05 11:42:44 -06:00

closed this issue
added the
bug

ready to close

short term
labels

gitea-mirror commented

2026-05-05 11:42:49 -06:00

Author

Owner

@ncfernan commented on GitHub (Jan 26, 2018):

I found the problem in worksheet.c:

@ncfernan commented on GitHub (Jan 26, 2018): I found the problem in **worksheet.c**: ![image](https://user-images.githubusercontent.com/10008844/35453393-39c1aa76-02b1-11e8-95a3-8a6e772624aa.png)

gitea-mirror commented

2026-05-05 11:42:50 -06:00

Author

Owner

@jmcnamara commented on GitHub (Jan 26, 2018):

Thanks for the report.

Could you add a small, compilable program that demonstrates the issue.

John

@jmcnamara commented on GitHub (Jan 26, 2018): Thanks for the report. Could you add a small, compilable program that demonstrates the issue. John

gitea-mirror commented

2026-05-05 11:42:54 -06:00

Author

Owner

@RaFaeL-NN commented on GitHub (Jan 29, 2018):

I sent out the same report a month ago. The problem is especially relevant when using the library with other programming languages in binary form. The best way is to split the options into two structures - one for external user use with 4 fields as a parameter, and the second one complete for internal

@RaFaeL-NN commented on GitHub (Jan 29, 2018): I sent out the same report a month ago. The problem is especially relevant when using the library with other programming languages in binary form. The best way is to split the options into two structures - one for external user use with 4 fields as a parameter, and the second one complete for internal

gitea-mirror commented

2026-05-05 11:42:56 -06:00

Author

Owner

@jmcnamara commented on GitHub (Jan 29, 2018):

@ncfernan You will need to initialize the lxw_image_options struct since it includes some non public members.

lxw_image_options options = {0};

However, I'll split the external and internal structs in a future release to avoid this type of issue.

@jmcnamara commented on GitHub (Jan 29, 2018): @ncfernan You will need to initialize the `lxw_image_options` struct since it includes some non public members. ```C lxw_image_options options = {0}; ``` However, I'll split the external and internal structs in a future release to avoid this type of issue.

gitea-mirror commented

2026-05-05 11:42:58 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 4, 2018):

I've pushed a fix for this issue to the master branch. It will be in the next release.

@jmcnamara commented on GitHub (Feb 4, 2018): I've pushed a fix for this issue to the master branch. It will be in the next release.

gitea-mirror commented

2026-05-05 11:43:01 -06:00

Author

Owner

@ncfernan commented on GitHub (Feb 4, 2018):

Thank you, John. That was the best response for an issue that I've seen in a long time. Keep up the excellent work!

@ncfernan commented on GitHub (Feb 4, 2018): Thank you, John. That was the best response for an issue that I've seen in a long time. Keep up the excellent work!

gitea-mirror commented

2026-05-05 11:43:04 -06:00

Author

Owner

@jmcnamara commented on GitHub (Feb 4, 2018):

Thanks. :-)

@jmcnamara commented on GitHub (Feb 4, 2018): Thanks. :-)