github-starred/libxlsxwriter
2
0
Fork 0
mirror of https://github.com/jmcnamara/libxlsxwriter.git synced 2026-05-15 14:15:54 -06:00
Code Issues 16 Projects Packages Wiki Activity Actions

workbook: fix buffer underflow in defined names

Browse source 
Closes #444
This commit is contained in:
John McNamara 2024-05-16 00:53:08 +01:00
parent 284b61ba0b
commit af0b03a8f0
2 changed files with 42 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

25
test/unit/workbook/test_workbook_write_defined_names.c
View file

@ -65,3 +65,28 @@ CTEST(workbook, write_defined_names_sorted) {
lxw_workbook_free(workbook);
}
/* Test invalid names formats. */
CTEST(workbook, write_defined_names_invalid) {
char* got;
char exp[] = "";
FILE* testfile = lxw_tmpfile(NULL);
lxw_workbook *workbook = workbook_new(NULL);
workbook->file = testfile;
workbook_add_worksheet(workbook, NULL);
workbook_define_name(workbook, "", "=123");
workbook_define_name(workbook, "Foo", "");
workbook_define_name(workbook, "Sheet1!", "=123");
workbook_define_name(workbook, "!", "=123");
_write_defined_names(workbook);
RUN_XLSX_STREQ(exp, got);
lxw_workbook_free(workbook);
}