From 051a01a2c31eb55fa467964a2c2328cfb8bcbde8 Mon Sep 17 00:00:00 2001
From: John McNamara <jmcnamara@cpan.org>
Date: Tue, 1 Jul 2025 00:12:54 +0100
Subject: [PATCH] Prep for release 1.2.3.

---
 .gitignore                                    |  2 +
 Changes.txt                                   | 37 +++++++++++++------
 dev/release/release_check.sh                  |  6 +--
 .../{update_revison.pl => update_revision.pl} |  0
 include/xlsxwriter.h                          |  6 +--
 include/xlsxwriter/workbook.h                 |  2 +
 libxlsxwriter.podspec                         |  4 +-
 7 files changed, 38 insertions(+), 19 deletions(-)
 rename dev/release/{update_revison.pl => update_revision.pl} (100%)

diff --git a/.gitignore b/.gitignore
index 6c07a13d..2570dc36 100644
--- a/.gitignore
+++ b/.gitignore
@@ -58,3 +58,5 @@ third_party/zlib-1.2.8/zlib.pc
 
 *zig-cache/
 zig-out/
+
+.swiftpm/
\ No newline at end of file
diff --git a/Changes.txt b/Changes.txt
index cf273daa..ee9880a1 100644
--- a/Changes.txt
+++ b/Changes.txt
@@ -1,6 +1,32 @@
 /**
 @page changes Changes
 
+## Information for Packagers
+
+- This is serial version 1.2.3. This is not a semver version number.
+
+- This is shared object library version `libxlsxwriter.so.10`. This should be
+  updated automatically via `make` and `cmake` as part of the build process.
+
+- Please report any downstream patches back upstream to help improve the overall
+  build process.
+
+
+## 1.2.3 Jun 30 2025
+
+- Added support for handling dates in the Excel 1904 epoch. See
+  `workbook_use_1904_epoch()`.
+
+  Feature request [#483][gh_483].
+
+  [gh_483]: https://github.com/jmcnamara/libxlsxwriter/issues/483
+
+- Fixed undefined behavior bugs in string indexing.
+
+  Issue [#482][gh_482].
+
+  [gh_482]: https://github.com/jmcnamara/libxlsxwriter/issues/482
+
 
 ## 1.2.2 March 29 2025
 
@@ -13,17 +39,6 @@
   [gh_477]: https://github.com/jmcnamara/libxlsxwriter/issues/477
 
 
-### Information for Packagers:
-
-- This is shared object library version `libxlsxwriter.so.9`. This should be
-  updated automatically via `make` and `cmake` as part of the build process.
-
-- This is serial version 1.2.2. This is not a semver version number.
-
-- Please report any downstream patches back upstream to help improve the overall
-  build process.
-
-
 ## 1.2.1 February 26 2025
 
 - Added the `workbook_set_size()` function to set the size of the window when
diff --git a/dev/release/release_check.sh b/dev/release/release_check.sh
index bceb4eed..a415c734 100755
--- a/dev/release/release_check.sh
+++ b/dev/release/release_check.sh
@@ -98,7 +98,7 @@ function check_changefile {
     clear
 
     echo "Latest change in Changes file: "
-    perl -ne '$rev++ if /^##/; exit if $rev > 1; print "    | $_"' Changes.txt
+    perl -ne '$rev++ if /^##/; exit if $rev > 2; print "    | $_"' Changes.txt
 
     echo
     echo -n "Is the Changes file updated?               [y/N]: "
@@ -140,7 +140,7 @@ function check_versions {
             exit 1
         else
             echo "    Updating versions...";
-            perl -i dev/release/update_revison.pl include/xlsxwriter.h libxlsxwriter.podspec
+            perl -i dev/release/update_revision.pl include/xlsxwriter.h libxlsxwriter.podspec
             check_versions
          fi
     fi
@@ -291,7 +291,7 @@ function check_git_status {
         echo -e "Please fix git status.\n";
 
         echo -e "\ngit add -u";
-        git tag -l -n1 | tail -1 | perl -lane 'printf "git commit -m \"Prep for release %s\"\ngit tag \"%s\"\n\n", $F[4], $F[0]' | perl dev/release/update_revison.pl
+        git tag -l -n1 | tail -1 | perl -lane 'printf "git commit -m \"Prep for release %s\"\ngit tag \"%s\"\n\n", $F[4], $F[0]' | perl dev/release/update_revision.pl
         exit 1
     fi
 }
diff --git a/dev/release/update_revison.pl b/dev/release/update_revision.pl
similarity index 100%
rename from dev/release/update_revison.pl
rename to dev/release/update_revision.pl
diff --git a/include/xlsxwriter.h b/include/xlsxwriter.h
index 756dbc78..fb41018b 100644
--- a/include/xlsxwriter.h
+++ b/include/xlsxwriter.h
@@ -19,8 +19,8 @@
 #include "xlsxwriter/format.h"
 #include "xlsxwriter/utility.h"
 
-#define LXW_VERSION "1.2.2"
-#define LXW_VERSION_ID 122
-#define LXW_SOVERSION "9"
+#define LXW_VERSION "1.2.3"
+#define LXW_VERSION_ID 123
+#define LXW_SOVERSION "10"
 
 #endif /* __LXW_XLSXWRITER_H__ */
diff --git a/include/xlsxwriter/workbook.h b/include/xlsxwriter/workbook.h
index d3d5d3b3..f10f1f5e 100644
--- a/include/xlsxwriter/workbook.h
+++ b/include/xlsxwriter/workbook.h
@@ -1087,6 +1087,8 @@ void workbook_read_only_recommended(lxw_workbook *workbook);
  * be set for compatibility with older versions of Excel or to work around the
  * Excel limitation of not being able to handle negative times.
  *
+ * This function should be called before `worksheet_add_worksheet()`.
+ *
  * @code
  *     workbook_use_1904_epoch(workbook);
  * @endcode
diff --git a/libxlsxwriter.podspec b/libxlsxwriter.podspec
index 27c41e3f..365b5939 100644
--- a/libxlsxwriter.podspec
+++ b/libxlsxwriter.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name                  = "libxlsxwriter"
-  s.version               = "1.2.2"
+  s.version               = "1.2.3"
   s.summary               = "Libxlsxwriter: A C library for creating Excel XLSX files."
   s.ios.deployment_target = "12.0"
   s.osx.deployment_target = "10.13"
@@ -21,7 +21,7 @@ Pod::Spec.new do |s|
                             * Worksheet PNG/JPEG/GIF images.
                             * Cell comments.
                             * Support for adding Macros.
-                            * Memory optimisation mode for writing large files.
+                            * Memory optimization mode for writing large files.
                             * Source code available on [GitHub](https://github.com/jmcnamara/libxlsxwriter).
                             * FreeBSD license.
                             * ANSI C.