[PR #395] [MERGED] fix: nix evaluation warnings + flake improvements #402

New issue

Closed

opened 2026-05-05 22:18:19 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 22:18:19 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/feschber/lan-mouse/pull/395
Author: @onelocked
Created: 3/9/2026
Status: ✅ Merged
Merged: 3/24/2026
Merged by: @feschber

Base: main ← Head: main

📝 Commits (6)

4b01b88 fix: nix evaluation warning
9900ec1 nix: minor flake improvements/maintenance
0826eac nix: fix macos build errors
98268e1 nix: minor cleanup/fixes
8415a19 nix: remove redundant deps
478aeef nix: remove reliance on systems input

📊 Changes

3 files changed (+113 additions, -84 deletions)

View changed files

📝 flake.lock (+6 -6)
📝 flake.nix (+83 -56)
📝 nix/default.nix (+24 -22)

📄 Description

Hey I am using the flake and home manager module.
I started getting these evaluation warnings, so I decided to look into it.

evaluation warning: The xorg package set has been deprecated, 'xorg.libX11' has been renamed to 'libx11'
evaluation warning: The xorg package set has been deprecated, 'xorg.libXtst' has been renamed to 'libxtst'

Main change
I've renamed xorg.libX11 and xorg.libXtst to libX11 and libXtst respectively, to fix the evaluation warning

Additional changes:

    wrapProgram "$out/bin/lan-mouse" \
      --set GDK_PIXBUF_MODULE_FILE ${pkgs.librsvg.out}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache

Was dropped in favor of wrapGAppsHook4, which does it automatically.

I have also removed with pkgs; and instead list dependencies explicitly in the argument set, this aligns with how nixpkgs does it.

Side notes/Questions
I am not entirely sure if buildPackages.gtk4 cmake are required. I've kept them since they were here already.
I've tried building lan-mouse without them and it does build and it works, but I've only tested it on my x86_64-linux machine.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/feschber/lan-mouse/pull/395 **Author:** [@onelocked](https://github.com/onelocked) **Created:** 3/9/2026 **Status:** ✅ Merged **Merged:** 3/24/2026 **Merged by:** [@feschber](https://github.com/feschber) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (6) - [`4b01b88`](https://github.com/feschber/lan-mouse/commit/4b01b88b3164d18de1caa94feba7ad5556022ca5) fix: nix evaluation warning - [`9900ec1`](https://github.com/feschber/lan-mouse/commit/9900ec18ea44188d4cfebf742dd08448f68ef73b) nix: minor flake improvements/maintenance - [`0826eac`](https://github.com/feschber/lan-mouse/commit/0826eac2812a99e5c804f388853c1c31632dd354) nix: fix macos build errors - [`98268e1`](https://github.com/feschber/lan-mouse/commit/98268e113465f479eeb720424096ef4880e9f93e) nix: minor cleanup/fixes - [`8415a19`](https://github.com/feschber/lan-mouse/commit/8415a197cbe66ab4dc90650a7999713ae6e04157) nix: remove redundant deps - [`478aeef`](https://github.com/feschber/lan-mouse/commit/478aeefa38a6e1e167bb1c124bd679e06e7deed1) nix: remove reliance on systems input ### 📊 Changes **3 files changed** (+113 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `flake.lock` (+6 -6) 📝 `flake.nix` (+83 -56) 📝 `nix/default.nix` (+24 -22) </details> ### 📄 Description Hey I am using the flake and home manager module. I started getting these evaluation warnings, so I decided to look into it. ```nix evaluation warning: The xorg package set has been deprecated, 'xorg.libX11' has been renamed to 'libx11' evaluation warning: The xorg package set has been deprecated, 'xorg.libXtst' has been renamed to 'libxtst' ``` **Main change** I've renamed `xorg.libX11` and `xorg.libXtst` to `libX11` and `libXtst` respectively, to fix the evaluation warning **Additional changes:** ```nix wrapProgram "$out/bin/lan-mouse" \ --set GDK_PIXBUF_MODULE_FILE ${pkgs.librsvg.out}/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache ``` Was dropped in favor of wrapGAppsHook4, which does it automatically. I have also removed `with pkgs;` and instead list dependencies explicitly in the argument set, this aligns with how nixpkgs does it. **Side notes/Questions** I am not entirely sure if `buildPackages.gtk4` `cmake` are required. I've kept them since they were here already. I've tried building lan-mouse without them and it does build and it works, but I've only tested it on my x86_64-linux machine. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>