[PR #158] [MERGED] better capture error handling (specifically libei) #308

New issue

Closed

opened 2026-05-05 22:16:22 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 22:16:22 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/feschber/lan-mouse/pull/158
Author: @feschber
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @feschber

Base: main ← Head: capture-error-handling

📝 Commits (10+)

110b37e improve capture error handling
89ca9c3 improve libei error handling
8ba92ed its getting cleaner
9c0a405 prefer CancellationToken / Notify to channel
ebf7897 create capture session only if clients are active
ae3ea2c fix windows/mac + rename async_drop to terminate
8ba178d simplify cancellation of service
c58f5db fix missing Arc import
3f7dae6 fmt
252547d solve clippy except tomanyargs

📊 Changes

41 files changed (+2048 additions, -1512 deletions)

View changed files

📝 Cargo.lock (+17 -1)
📝 Cargo.toml (+24 -14)
📝 input-capture/Cargo.toml (+31 -9)
📝 input-capture/src/dummy.rs (+12 -5)
📝 input-capture/src/error.rs (+30 -0)
📝 input-capture/src/lib.rs (+22 -11)
📝 input-capture/src/libei.rs (+305 -321)
📝 input-capture/src/macos.rs (+14 -6)
📝 input-capture/src/wayland.rs (+23 -14)
📝 input-capture/src/windows.rs (+13 -6)
📝 input-capture/src/x11.rs (+12 -5)
📝 input-emulation/src/dummy.rs (+3 -0)
📝 input-emulation/src/error.rs (+29 -0)
📝 input-emulation/src/lib.rs (+3 -2)
📝 input-emulation/src/libei.rs (+77 -42)
📝 input-emulation/src/macos.rs (+2 -0)
📝 input-emulation/src/windows.rs (+2 -0)
📝 input-emulation/src/wlroots.rs (+3 -0)
📝 input-emulation/src/x11.rs (+4 -0)
📝 input-emulation/src/xdg_desktop_portal.rs (+20 -22)

...and 21 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/feschber/lan-mouse/pull/158 **Author:** [@feschber](https://github.com/feschber) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@feschber](https://github.com/feschber) **Base:** `main` ← **Head:** `capture-error-handling` --- ### 📝 Commits (10+) - [`110b37e`](https://github.com/feschber/lan-mouse/commit/110b37e26ef079dec9aec8a8b861c0e60ce6bbb3) improve capture error handling - [`89ca9c3`](https://github.com/feschber/lan-mouse/commit/89ca9c3c0baef79956bf80b4e4c367148f7ae52e) improve libei error handling - [`8ba92ed`](https://github.com/feschber/lan-mouse/commit/8ba92ede34204b9dae8e16f26e84a02810efeb20) its getting cleaner - [`9c0a405`](https://github.com/feschber/lan-mouse/commit/9c0a40563e2649870dca98cfd3dcf84726b6cab1) prefer CancellationToken / Notify to channel - [`ebf7897`](https://github.com/feschber/lan-mouse/commit/ebf7897caa1b14bcf3eddf6518664ea6c34ada41) create capture session only if clients are active - [`ae3ea2c`](https://github.com/feschber/lan-mouse/commit/ae3ea2c4970b561d54ef31ed966ae6ac8fa0ad9f) fix windows/mac + rename async_drop to terminate - [`8ba178d`](https://github.com/feschber/lan-mouse/commit/8ba178dce0718768fb8aa23729200018fceadc18) simplify cancellation of service - [`c58f5db`](https://github.com/feschber/lan-mouse/commit/c58f5dbdd51235575eeaaef21be217865c659249) fix missing Arc import - [`3f7dae6`](https://github.com/feschber/lan-mouse/commit/3f7dae65a2a40f24a40292d796c142e8e8b00926) fmt - [`252547d`](https://github.com/feschber/lan-mouse/commit/252547dfdb171bad81fb1bf8493cd493f1e8314e) solve clippy except tomanyargs ### 📊 Changes **41 files changed** (+2048 additions, -1512 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+17 -1) 📝 `Cargo.toml` (+24 -14) 📝 `input-capture/Cargo.toml` (+31 -9) 📝 `input-capture/src/dummy.rs` (+12 -5) 📝 `input-capture/src/error.rs` (+30 -0) 📝 `input-capture/src/lib.rs` (+22 -11) 📝 `input-capture/src/libei.rs` (+305 -321) 📝 `input-capture/src/macos.rs` (+14 -6) 📝 `input-capture/src/wayland.rs` (+23 -14) 📝 `input-capture/src/windows.rs` (+13 -6) 📝 `input-capture/src/x11.rs` (+12 -5) 📝 `input-emulation/src/dummy.rs` (+3 -0) 📝 `input-emulation/src/error.rs` (+29 -0) 📝 `input-emulation/src/lib.rs` (+3 -2) 📝 `input-emulation/src/libei.rs` (+77 -42) 📝 `input-emulation/src/macos.rs` (+2 -0) 📝 `input-emulation/src/windows.rs` (+2 -0) 📝 `input-emulation/src/wlroots.rs` (+3 -0) 📝 `input-emulation/src/x11.rs` (+4 -0) 📝 `input-emulation/src/xdg_desktop_portal.rs` (+20 -22) _...and 21 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>