mirror of
https://github.com/keycastr/keycastr.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #111] Add fn keys to Svelte Visualiser #89
Labels
No labels
bug
compatibility
discussion
documentation
enhancement
help wanted
help wanted
investigation needed
pull-request
release
visualizer
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/keycastr#89
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gwthm-in on GitHub (May 10, 2018).
Original GitHub issue: https://github.com/keycastr/keycastr/issues/111
I really appreciate the effort you put in making this. It will be really good if you can give choice to add modifier keys in Svelte Visualiser.
Or request to add fn keys as a modifier in Svelte Visualiser.
Currently, I see fn key is not shown as a modifier. I would like to request this as a feature. Though I never worked on Object C, I can give it a try and contribute if you guys help me.
Thank you :)
@lqez commented on GitHub (May 16, 2018):
I added
fninto Svelte but I'm not sure this could meet your requirement.When I press the left arrow key with
fn, it changed intohome, notfn + ⇦.@akitchen commented on GitHub (May 16, 2018):
Hello @gowtham-sai and thank you for using KeyCastr! - I am wondering, could you give a few examples of how you would use this and what you would expect to see? I think of
fnon macOS as giving us access fo the F-keys when the special feature keys are enabled on the F-key row. Do you have another use case in mind?@gwthm-in commented on GitHub (May 17, 2018):
IMHO I prefer to see only function key presses when somebody is pressing f1, f2 keys and etc. But with the latest mac, when function keys are swapped, if you think it is good to show other keys presses that are swapped in place of fun keys (for ex: chrome home keys when using chrome, if somebody presses it) you can show that as well.
But I prefer showing only fn keys, because when sombody presses chrome home button, they mean to go to chrome home page, but not mean to press f5 key.
@lqez commented on GitHub (Jun 14, 2018):
@akitchen I'm not sure about showing
fnstatus. If you think it could be worth to make it, I'll update the previous PR #112.@akitchen commented on GitHub (Jun 14, 2018):
I don't believe this is something that is useful to implement; at the end of the day, we care about (and display) F keys like F2, F8, etc. Whether the user needed to press the fn accessory key to provide that input isn't really relevant, as it's a personal preference whether to use the Function key row as F-keys vs. "App Control" keys.
We shouldn't clutter up the Svelte visualizer for this, but in theory the visualizer abstraction is pluggable, so someone could add their own visualizer if they want to customize the behavior.
@lqez commented on GitHub (Jun 15, 2018):
Thanks @akitchen !