[PR #226] [MERGED] Adds basic support for visualizing mouse clicks #327

New issue

Closed

opened 2026-05-05 05:13:16 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 05:13:16 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/keycastr/keycastr/pull/226
Author: @akitchen
Created: 2/14/2022
Status: ✅ Merged
Merged: 2/22/2022
Merged by: @akitchen

Base: main ← Head: mouse-support

📝 Commits (10+)

4c9cc15 (WIP) Adds an option to include mouse clicks, with a simple emoji
cbc3225 Improvements to mouse click visualization
cb1c3e6 Remove deprecated API usage
e473ffd Checkpoint adding options to configure the mouse visualizer
c1f05d9 Remove a few redundant declarations
7edf18f Fix up keystroke conversion tests following initializer change (+1 squashed commit)
68f12b0 Mouse visualizer updates when default visualizer color changes
82b5ae7 Adjust UI to display mouse options first
87a8ad1 Update deployment target to macOS 10.12 and fix some deprecated usages
79d4bbb Store user's selected mouse display option in NSUserDefaults

📊 Changes

37 files changed (+1192 additions, -455 deletions)

View changed files

📝 README.md (+30 -25)
➕ assets/KeyCastr_header.png (+0 -0)
➖ assets/display_all_keystrokes.png (+0 -0)
➖ assets/preferences.png (+0 -0)
➖ assets/preview.png (+0 -0)
📝 keycastr/Info.plist (+2 -0)
📝 keycastr/KCAppController.h (+0 -5)
📝 keycastr/KCAppController.m (+48 -22)
📝 keycastr/KCDefaultVisualizer.h (+1 -1)
📝 keycastr/KCDefaultVisualizer.m (+17 -14)
📝 keycastr/KCDefaultVisualizer.nib/designable.nib (+223 -148)
➕ keycastr/KCDefaultVisualizer.nib/keyedobjects-101300.nib (+0 -0)
📝 keycastr/KCDefaultVisualizer.nib/keyedobjects.nib (+0 -0)
📝 keycastr/KCKeyboardTap.h (+6 -7)
📝 keycastr/KCKeyboardTap.m (+44 -17)
➕ keycastr/KCKeycastrEvent.h (+41 -0)
➕ keycastr/KCKeycastrEvent.m (+58 -0)
📝 keycastr/KCKeystroke.h (+2 -7)
📝 keycastr/KCKeystroke.m (+14 -13)
📝 keycastr/KCKeystrokeTransformer.m (+6 -5)

...and 17 more files

📄 Description

This first bit of functionality for supporting visualization of mouse clicks works similar to Quicktime screen recordings. Some speculative code is also included for forwarding mouse events to the keystroke visualizers, but is not yet enabled.

Mouse click visualization is in the same color as the default visualizer bezel. We could make this user-configurable in the near future, if there is interest.
Mouse click visualization uses a fixed/hard-coded radius and the default fade animation duration. Unclear whether either of these should be made adjustable.
A bunch of other cleanup is included, adjacent to the modified code.

This adds the first steps necessary to implement #33 , and should address #168.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/keycastr/keycastr/pull/226 **Author:** [@akitchen](https://github.com/akitchen) **Created:** 2/14/2022 **Status:** ✅ Merged **Merged:** 2/22/2022 **Merged by:** [@akitchen](https://github.com/akitchen) **Base:** `main` ← **Head:** `mouse-support` --- ### 📝 Commits (10+) - [`4c9cc15`](https://github.com/keycastr/keycastr/commit/4c9cc15f3edbaebd2ebfaf74f55db6f5bf353c5f) (WIP) Adds an option to include mouse clicks, with a simple emoji - [`cbc3225`](https://github.com/keycastr/keycastr/commit/cbc322572829a33cd16238aaf3dbfd0830ee9988) Improvements to mouse click visualization - [`cb1c3e6`](https://github.com/keycastr/keycastr/commit/cb1c3e65cdc78a932c28f90f69c2cef0b74f825f) Remove deprecated API usage - [`e473ffd`](https://github.com/keycastr/keycastr/commit/e473ffdeb803690a67bc3db17c4aa514a0bb0cb7) Checkpoint adding options to configure the mouse visualizer - [`c1f05d9`](https://github.com/keycastr/keycastr/commit/c1f05d9e498407bd3c1166f2ce9634ee09ac2333) Remove a few redundant declarations - [`7edf18f`](https://github.com/keycastr/keycastr/commit/7edf18f7385e8ce45a46688e7a55503f8b19b43d) Fix up keystroke conversion tests following initializer change (+1 squashed commit) - [`68f12b0`](https://github.com/keycastr/keycastr/commit/68f12b06c867960808000b4a7b3d6f57acf2e14d) Mouse visualizer updates when default visualizer color changes - [`82b5ae7`](https://github.com/keycastr/keycastr/commit/82b5ae7caf0170f3ccf47a5d7e6b8b5bf4fd130e) Adjust UI to display mouse options first - [`87a8ad1`](https://github.com/keycastr/keycastr/commit/87a8ad1e3ba6994f29a074ecb735369ecfb2ebfe) Update deployment target to macOS 10.12 and fix some deprecated usages - [`79d4bbb`](https://github.com/keycastr/keycastr/commit/79d4bbb9aec0e8b4164a80b0c61a013081da7311) Store user's selected mouse display option in NSUserDefaults ### 📊 Changes **37 files changed** (+1192 additions, -455 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+30 -25) ➕ `assets/KeyCastr_header.png` (+0 -0) ➖ `assets/display_all_keystrokes.png` (+0 -0) ➖ `assets/preferences.png` (+0 -0) ➖ `assets/preview.png` (+0 -0) 📝 `keycastr/Info.plist` (+2 -0) 📝 `keycastr/KCAppController.h` (+0 -5) 📝 `keycastr/KCAppController.m` (+48 -22) 📝 `keycastr/KCDefaultVisualizer.h` (+1 -1) 📝 `keycastr/KCDefaultVisualizer.m` (+17 -14) 📝 `keycastr/KCDefaultVisualizer.nib/designable.nib` (+223 -148) ➕ `keycastr/KCDefaultVisualizer.nib/keyedobjects-101300.nib` (+0 -0) 📝 `keycastr/KCDefaultVisualizer.nib/keyedobjects.nib` (+0 -0) 📝 `keycastr/KCKeyboardTap.h` (+6 -7) 📝 `keycastr/KCKeyboardTap.m` (+44 -17) ➕ `keycastr/KCKeycastrEvent.h` (+41 -0) ➕ `keycastr/KCKeycastrEvent.m` (+58 -0) 📝 `keycastr/KCKeystroke.h` (+2 -7) 📝 `keycastr/KCKeystroke.m` (+14 -13) 📝 `keycastr/KCKeystrokeTransformer.m` (+6 -5) _...and 17 more files_ </details> ### 📄 Description This first bit of functionality for supporting visualization of mouse clicks works similar to Quicktime screen recordings. Some speculative code is also included for forwarding mouse events to the keystroke visualizers, but is not yet enabled. - Mouse click visualization is in the same color as the default visualizer bezel. We could make this user-configurable in the near future, if there is interest. - Mouse click visualization uses a fixed/hard-coded radius and the default fade animation duration. Unclear whether either of these should be made adjustable. - A bunch of other cleanup is included, adjacent to the modified code. This adds the first steps necessary to implement #33 , and should address #168. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>