[PR #108] [MERGED] Fixes visualizer persisting across spaces #314

New issue

Closed

opened 2026-05-05 05:12:41 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 05:12:41 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/keycastr/keycastr/pull/108
Author: @Jamedjo
Created: 3/29/2018
Status: ✅ Merged
Merged: 4/19/2018
Merged by: @akitchen

Base: master ← Head: fix-persist-across-all-desktops

📝 Commits (1)

c953d8a Fixes visualizer persisting across spaces

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 keycastr/KCDefaultVisualizer.m (+1 -0)

📄 Description

What

Sets the visualizer to canJoinAllSpaces so it appears on all desktops, instead of being left behind when switching.

Why

When moving across spaces or desktops the visualizer was left on the first one. This made it hard when switching between apps on different desktops, e.g. when demoing a browser on one desktop and switching to code in another

Why not

It might be be preferable to use moveToActiveSpace instead, so it doesn't appear on multiple monitors. Users with multiple screens could also want an option between the two.

Fixes #64

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/keycastr/keycastr/pull/108 **Author:** [@Jamedjo](https://github.com/Jamedjo) **Created:** 3/29/2018 **Status:** ✅ Merged **Merged:** 4/19/2018 **Merged by:** [@akitchen](https://github.com/akitchen) **Base:** `master` ← **Head:** `fix-persist-across-all-desktops` --- ### 📝 Commits (1) - [`c953d8a`](https://github.com/keycastr/keycastr/commit/c953d8a1914b5991d3ddc15745fbe918fca667d0) Fixes visualizer persisting across spaces ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `keycastr/KCDefaultVisualizer.m` (+1 -0) </details> ### 📄 Description ## What Sets the visualizer to `canJoinAllSpaces` so it appears on all desktops, instead of being left behind when switching. ## Why When moving across spaces or desktops the visualizer was left on the first one. This made it hard when switching between apps on different desktops, e.g. when demoing a browser on one desktop and switching to code in another ## Why not It might be be preferable to use `moveToActiveSpace` instead, so it doesn't appear on multiple monitors. Users with multiple screens could also want an option between the two. Fixes #64 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>