[PR #24] [MERGED] Modifier keys should not display as ^A #292

New issue

Closed

opened 2026-05-05 05:12:04 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 05:12:04 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/keycastr/keycastr/pull/24
Author: @tjarratt
Created: 5/7/2015
Status: ✅ Merged
Merged: 5/7/2015
Merged by: @akitchen

Base: master ← Head: fix-modifier-keys-unicode-values

📝 Commits (2)

41e40d1 Properly fix default visualizer
6a6d917 Add xcsharedata to gitignore

📊 Changes

2 files changed (+6 additions, -5 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 keycastr/KCKeystrokeTransformer.m (+5 -5)

📄 Description

This fixes issue #23.

I don't have a lot of experience creating unicode characters from hexadecimal values in objective-c, but everything I've seen implies that it's incorrect to append an extra \x01 at the end. In the svelte visualizer, for example, these same hex strings appear, without the trailing \x01.

I also added a commit that adds xcsharedata to the gitignore. This is common to do for projects using XCode 5 or newer, when they added support for schemes. Since non-shared schemes belong to the user that created them, not having this ignored often results in a lot of noisy files being created that should not be tracked by git.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/keycastr/keycastr/pull/24 **Author:** [@tjarratt](https://github.com/tjarratt) **Created:** 5/7/2015 **Status:** ✅ Merged **Merged:** 5/7/2015 **Merged by:** [@akitchen](https://github.com/akitchen) **Base:** `master` ← **Head:** `fix-modifier-keys-unicode-values` --- ### 📝 Commits (2) - [`41e40d1`](https://github.com/keycastr/keycastr/commit/41e40d14d705396760b4984d3b9dc45837500bbc) Properly fix default visualizer - [`6a6d917`](https://github.com/keycastr/keycastr/commit/6a6d9170ae8d3e8d92eab586557d720d97ab671e) Add xcsharedata to gitignore ### 📊 Changes **2 files changed** (+6 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `keycastr/KCKeystrokeTransformer.m` (+5 -5) </details> ### 📄 Description This fixes issue #23. I don't have a lot of experience creating unicode characters from hexadecimal values in objective-c, but everything I've seen implies that it's incorrect to append an extra `\x01` at the end. In the svelte visualizer, for example, these same hex strings appear, without the trailing `\x01`. I also added a commit that adds xcsharedata to the gitignore. This is common to do for projects using XCode 5 or newer, when they added support for schemes. Since non-shared schemes belong to the user that created them, not having this ignored often results in a lot of noisy files being created that should not be tracked by git. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>