mirror of
https://github.com/keycastr/keycastr.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #23] Command shortcuts not displaying, ^A instead #22
Labels
No labels
bug
compatibility
discussion
documentation
enhancement
help wanted
help wanted
investigation needed
pull-request
release
visualizer
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/keycastr#22
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @aaronjensen on GitHub (Apr 19, 2015).
Original GitHub issue: https://github.com/keycastr/keycastr/issues/23
At least on OSX 10.10.3 #6 is happening again.
@aaronjensen commented on GitHub (Apr 19, 2015):
Not sure if it does, but this may fix it: https://github.com/creemama/keycastr/pull/1
@akitchen commented on GitHub (Apr 19, 2015):
This is a strange one. @tjarratt and I have talked about it in person, but I use the app nearly daily in my work and have never run into it.
We will look into it more soon. Thanks!
On Sun, Apr 19, 2015 at 11:48 AM, Aaron Jensen notifications@github.com
wrote:
@tjarratt commented on GitHub (Apr 19, 2015):
Interestingly enough, I too can reproduce this with the default visualizer. My proposed fix to creemama's fork looks silly to my eyes today, because it shouldn't have fixed anything. I'll look into it a bit more, maybe I've learned a thing or two in the past two years and will be able to fix it for good this time.
Thanks, @akitchen for pinging me to this thread!
@tjarratt commented on GitHub (Apr 20, 2015):
The problem seems to stem from how we are creating the UTF8 encoded strings that represent the control keys. With a little debugging, I found that if I typed ⌘ + A (for example), then the actual string that would be created was
`"⌘\x01A"
I tracked this down to where some constants are created that should be the proper unicode representation of command, control, option, etcetera.
KCKeystrokeTransformer.m
Getting rid of those trailing
\x01fixes the bug for me, although I'm not certain at the moment why they are there in the first place.@tjarratt commented on GitHub (Apr 20, 2015):
Seems like VLC at some point had some similar code, albeit without the trailing \x01.
I'd love to issue a pull request that fixes this, but I'm also really curious why this only fails on some machines.
@tjarratt commented on GitHub (Apr 20, 2015):
I have a potential fix on a branch. Would love any feedback, suggestions, or explanations of the actual root cause here.
Perhaps you could try that out, @aaronjensen, and let me know if it works for you as well?
@aaronjensen commented on GitHub (Apr 20, 2015):
@tjarratt the fix works for me. I have no idea why it would work for some and not others before... odd.
@akitchen commented on GitHub (May 7, 2015):
Please open a pull request with your fix @tjarratt ! Sounds like this would be helpful.
@akitchen commented on GitHub (May 16, 2015):
Please build and install from master for now, we will try to cut a new official release once we can update the version number in the UI / legacy nib #26