mirror of
https://github.com/keycastr/keycastr.git
synced 2026-05-15 14:15:50 -06:00
[GH-ISSUE #144] Non-existent symlinks exist in release zip file #120
Labels
No labels
bug
compatibility
discussion
documentation
enhancement
help wanted
help wanted
investigation needed
pull-request
release
visualizer
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/keycastr#120
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @goranmoomin on GitHub (Oct 16, 2019).
Original GitHub issue: https://github.com/keycastr/keycastr/issues/144
While I was investigating a failing
brew caskinstall of keycastr:So I unzipped the file manually and tried to investigate what is the non-existent files.
I'm not sure why the wrong symlinks are there (my crude guess is that you're locale is french and macOS treats the developer's locale specially?), but I think they should be removed from the release zip file.
@akitchen commented on GitHub (Oct 16, 2019):
Thanks for reporting. This is the first I’ve heard of this, and this cask has been released for a long time — in fact we’re overdue for an update.
It looks like this is an issue within Sparkle, which is broken and unused anyways. We have a little work to do to remove it.
I don’t think this is related to my locale, I’d bet it’s an issue with a newer version of macOS. What version are you using (and is brew doctor otherwise happy?)
On Oct 15, 2019, 17:20 -0700, 조성빈 notifications@github.com, wrote:
@goranmoomin commented on GitHub (Oct 16, 2019):
@akitchen Maybe it's a behavior change of
xattron macOS 10.15 (thatxattrbalks on non-existent symlinks), but the issue itself remains, the release build shouldn't contain the symlinks to your development directory; (for example your username is exposed! :-))@akitchen commented on GitHub (Oct 17, 2019):
It’s weird, I’ve never encountered this on numerous machines, and that’s not my username 🤷♂️
@akitchen commented on GitHub (Dec 17, 2020):
hi @pcr910303 I recently converted Sparkle to be a cross-project dependency instead of checked-in framework, in order to build for Apple Silicon. I ran your same command on the newer built version of Sparkle and it no longer symlinks out to a path on
andym's filesystem.The issue you mentioned and the effect on brew cask will be fixed indirectly in v0.9.9. Thank you for opening the issue!