github-starred/keycastr
2
0
Fork 0
mirror of https://github.com/keycastr/keycastr.git synced 2026-05-15 06:06:06 -06:00
Code Issues 96 Projects Packages Wiki Activity Actions

Fix leak of Svelte visualizer when switching visualizers

Browse source
This commit is contained in:
Andrew Kitchen 2024-11-26 20:18:19 -08:00
parent 27a65072cc
commit c57433882f
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
keycastr/SvelteVisualizer.m
View file

@ -169,10 +169,15 @@
@end
@interface SvelteVisualizer ()
@property (nonatomic, assign) BOOL displayAll;
@end
@implementation SvelteVisualizer {
NSWindow *_visualizerWindow;
SvelteVisualizerView *_visualizerView;
BOOL _displayAll;
}
-(NSString*) visualizerName
@ -199,17 +204,18 @@
[_visualizerWindow setOpaque:NO];
[_visualizerWindow setCollectionBehavior:NSWindowCollectionBehaviorCanJoinAllSpaces];
_visualizerView = [[[SvelteVisualizerView alloc] initWithFrame:r] autorelease];
_visualizerView = [[SvelteVisualizerView alloc] initWithFrame:r];
[_visualizerWindow setContentView:_visualizerView];
_displayAll = [[[NSUserDefaults standardUserDefaults] valueForKey:@"svelte.displayAll"] boolValue];
// TODO: migrate away from using NSNotificationCenter for this, as it is far too chatty
__weak typeof(self) weakSelf = self;
[[NSNotificationCenter defaultCenter] addObserverForName:NSUserDefaultsDidChangeNotification
object:nil
queue:nil
usingBlock:^(NSNotification * _Nonnull notification) {
_displayAll = [notification.object boolForKey:@"svelte.displayAll"];
weakSelf.displayAll = [notification.object boolForKey:@"svelte.displayAll"];
}];
return self;