mirror of
https://github.com/mmatczuk/go-http-tunnel.git
synced 2026-05-15 06:06:03 -06:00
[PR #83] Allow setting the server hostname for TLS connection #138
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/go-http-tunnel#138
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/mmatczuk/go-http-tunnel/pull/83
Author: @ameir
Created: 7/11/2018
Status: 🔄 Open
Base:
master← Head:allow-specify-server-hostname📝 Commits (1)
53684eaWhen using SAN certs, hostname verification is enforced. If the server hostname inserver_addrdoesn't match one of the names in the cert, then the connection fails. This PR allows you to specify an allowed hostname. The use-case for this is that we have auto-generated certs per node in AWS, but are establishing the tunnel through an NLB. The NLB hostname does not match what is in the cert, so the connection fails without this patch.📊 Changes
2 files changed (+15 additions, -10 deletions)
View changed files
📝
cmd/tunnel/config.go(+7 -6)📝
cmd/tunnel/tunnel.go(+8 -4)📄 Description
When using SAN certs, hostname verification is enforced. If the server hostname in
server_addrdoesn't match one of the names in the cert, thenthe connection fails. This PR allows you to specify an allowed hostname. The use-case for this is that we have auto-generated certs per node in AWS,but are establishing the tunnel through an NLB. The NLB hostname does not match what is in the cert, so the connection fails without this patch.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.