github-starred/go-http-tunnel
2
0
Fork 0
mirror of https://github.com/mmatczuk/go-http-tunnel.git synced 2026-05-15 14:16:17 -06:00
Code Issues 61 Projects Packages Wiki Activity Actions

[PR #59] [MERGED] Removal of panics #130

New issue
Closed
opened 2026-05-05 11:02:09 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 11:02:09 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/mmatczuk/go-http-tunnel/pull/59
Author: @mmatczuk
Created: 11/25/2017
Status: ✅ Merged
Merged: 11/25/2017
Merged by: @mmatczuk

Base: master ← Head: mmt/panic

📝 Commits (3)

  • af65ca0 id: removal of unused constructors
  • 99ea4dc tunnel: removal of panics
  • 78018df tunnel: handle no tunnels with a message

📊 Changes

7 files changed (+45 additions, -57 deletions)

View changed files

📝 client.go (+8 -7)
📝 client_test.go (+10 -5)
📝 cmd/tunnel/tunnel.go (+10 -3)
📝 httpproxy.go (+6 -11)
📝 id/id.go (+0 -19)
📝 integration_test.go (+10 -3)
📝 tcpproxy.go (+1 -9)

📄 Description

This PR replaces panics with errors where needed. It also handles start-all when there are no tunnels with a proper message displayed to the user.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mmatczuk/go-http-tunnel/pull/59 **Author:** [@mmatczuk](https://github.com/mmatczuk) **Created:** 11/25/2017 **Status:** ✅ Merged **Merged:** 11/25/2017 **Merged by:** [@mmatczuk](https://github.com/mmatczuk) **Base:** `master` ← **Head:** `mmt/panic` --- ### 📝 Commits (3) - [`af65ca0`](https://github.com/mmatczuk/go-http-tunnel/commit/af65ca03cd7145d869e5731df6733ec8209c766e) id: removal of unused constructors - [`99ea4dc`](https://github.com/mmatczuk/go-http-tunnel/commit/99ea4dc27328572233d016d2a9c19f224fa6ea8e) tunnel: removal of panics - [`78018df`](https://github.com/mmatczuk/go-http-tunnel/commit/78018df0ee9e089d791c4eba2d37e1cad79fa204) tunnel: handle no tunnels with a message ### 📊 Changes **7 files changed** (+45 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `client.go` (+8 -7) 📝 `client_test.go` (+10 -5) 📝 `cmd/tunnel/tunnel.go` (+10 -3) 📝 `httpproxy.go` (+6 -11) 📝 `id/id.go` (+0 -19) 📝 `integration_test.go` (+10 -3) 📝 `tcpproxy.go` (+1 -9) </details> ### 📄 Description This PR replaces panics with errors where needed. It also handles `start-all` when there are no tunnels with a proper message displayed to the user. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 11:02:09 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/golang.org/x/net-0.38.0
revert-110-hotfix/dependency
mmt/websocket
mmt/old-websocket
2.1
v.2.0
v.1.2
v.1.1
v.1.0
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/go-http-tunnel#130
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?