github-starred/go-http-tunnel
2
0
Fork 0
mirror of https://github.com/mmatczuk/go-http-tunnel.git synced 2026-05-15 14:16:17 -06:00
Code Issues 61 Projects Packages Wiki Activity Actions

[PR #45] [MERGED] Connection leak fix #120

New issue
Closed
opened 2026-05-05 11:01:54 -06:00 by gitea-mirror · 0 comments
gitea-mirror commented 2026-05-05 11:01:54 -06:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/mmatczuk/go-http-tunnel/pull/45
Author: @mmatczuk
Created: 11/14/2017
Status: ✅ Merged
Merged: 11/15/2017
Merged by: @mmatczuk

Base: master ← Head: mmt/leak_fix

📝 Commits (3)

  • 24d47f6 integration test: added logging
  • b9a3c64 transfer: don't close connections in transfer
  • df12873 transfer: change signature to accept only reader

📊 Changes

4 files changed (+31 additions, -40 deletions)

View changed files

📝 integration_test.go (+5 -5)
📝 server.go (+16 -11)
📝 tcpproxy.go (+1 -0)
📝 utils.go (+9 -24)

📄 Description

This PR fixes https://github.com/mmatczuk/go-http-tunnel/issues/44, transfer function is not closing connections anymore. Connections are closed externally after transferring data both ways.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mmatczuk/go-http-tunnel/pull/45 **Author:** [@mmatczuk](https://github.com/mmatczuk) **Created:** 11/14/2017 **Status:** ✅ Merged **Merged:** 11/15/2017 **Merged by:** [@mmatczuk](https://github.com/mmatczuk) **Base:** `master` ← **Head:** `mmt/leak_fix` --- ### 📝 Commits (3) - [`24d47f6`](https://github.com/mmatczuk/go-http-tunnel/commit/24d47f6746cb94e00df785a94b27b64633bb0202) integration test: added logging - [`b9a3c64`](https://github.com/mmatczuk/go-http-tunnel/commit/b9a3c644cfed630552fa663e304c341e43f65ae6) transfer: don't close connections in transfer - [`df12873`](https://github.com/mmatczuk/go-http-tunnel/commit/df128734d89b1b9c9db69222486e81a9f04e4a38) transfer: change signature to accept only reader ### 📊 Changes **4 files changed** (+31 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `integration_test.go` (+5 -5) 📝 `server.go` (+16 -11) 📝 `tcpproxy.go` (+1 -0) 📝 `utils.go` (+9 -24) </details> ### 📄 Description This PR fixes https://github.com/mmatczuk/go-http-tunnel/issues/44, `transfer` function is not closing connections anymore. Connections are closed externally after transferring data both ways. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 11:01:54 -06:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/golang.org/x/net-0.38.0
revert-110-hotfix/dependency
mmt/websocket
mmt/old-websocket
2.1
v.2.0
v.1.2
v.1.1
v.1.0
Labels
Clear labels   
pull-request

Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/go-http-tunnel#120
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?