[PR #5262] [MERGED] client: close TCP connection when fmux session creation fails #5213

New issue

Closed

opened 2026-05-05 14:56:48 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:56:48 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/5262
Author: @cuiweixie
Created: 3/25/2026
Status: ✅ Merged
Merged: 3/29/2026
Merged by: @fatedier

Base: dev ← Head: fix/client-close-conn-on-fmux-error

📝 Commits (1)

5791633 client: close TCP connection when fmux session creation fails

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 client/connector.go (+1 -0)

📄 Description

Summary

Close the TCP connection when fmux.Client fails after realConnect() succeeds, since the connector does not retain the conn and it would otherwise leak.

PR targets dev per project contributing guidelines.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/5262 **Author:** [@cuiweixie](https://github.com/cuiweixie) **Created:** 3/25/2026 **Status:** ✅ Merged **Merged:** 3/29/2026 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `fix/client-close-conn-on-fmux-error` --- ### 📝 Commits (1) - [`5791633`](https://github.com/fatedier/frp/commit/579163379853e2150c39e767f928cea7d6949391) client: close TCP connection when fmux session creation fails ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `client/connector.go` (+1 -0) </details> ### 📄 Description ## Summary - Close the TCP connection when `fmux.Client` fails after `realConnect()` succeeds, since the connector does not retain the conn and it would otherwise leak. PR targets **dev** per project contributing guidelines. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>