[PR #5261] [CLOSED] nathole: return error when SetTTL fails in sendSidMessage #5212

New issue

Closed

opened 2026-05-05 14:56:47 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:56:47 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/5261
Author: @cuiweixie
Created: 3/25/2026
Status: ❌ Closed

Base: dev ← Head: fix/nathole-sendSidMessage-setttl-error

📝 Commits (1)

c4f5c44 nathole: return error when SetTTL fails in sendSidMessage

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 pkg/nathole/nathole.go (+1 -0)

📄 Description

Summary

Propagate SetTTL errors in sendSidMessage instead of only logging and continuing, so UDP is not sent with an unintended TTL when TTL setup fails.
Matches existing behavior for TTL() failures in the same path.

Context

Per Contributing, PR targets dev.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/5261 **Author:** [@cuiweixie](https://github.com/cuiweixie) **Created:** 3/25/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/nathole-sendSidMessage-setttl-error` --- ### 📝 Commits (1) - [`c4f5c44`](https://github.com/fatedier/frp/commit/c4f5c4421e7bfe7d737e710ae911a5f54a3a3ccb) nathole: return error when SetTTL fails in sendSidMessage ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `pkg/nathole/nathole.go` (+1 -0) </details> ### 📄 Description ## Summary - Propagate `SetTTL` errors in `sendSidMessage` instead of only logging and continuing, so UDP is not sent with an unintended TTL when TTL setup fails. - Matches existing behavior for `TTL()` failures in the same path. ## Context Per [Contributing](https://github.com/fatedier/frp/blob/dev/README.md#contributing), PR targets **dev**. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>