[PR #5231] [MERGED] test/e2e: replace sleeps with event-driven waits in chaos/group/store tests #5193

Closed
opened 2026-05-05 14:56:26 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/5231
Author: @fatedier
Created: 3/11/2026
Status: Merged
Merged: 3/11/2026
Merged by: @fatedier

Base: devHead: new


📝 Commits (2)

  • d4fe14e test/e2e: replace sleeps with event-driven waits in chaos/group/store tests
  • 1316da0 test/e2e: validate interval and cap dial/sleep to remaining deadline in WaitForTCPUnreachable

📊 Changes

5 files changed (+57 additions, -25 deletions)

View changed files

📝 test/e2e/framework/process.go (+24 -0)
📝 test/e2e/pkg/process/process.go (+5 -0)
📝 test/e2e/v1/features/chaos.go (+5 -5)
📝 test/e2e/v1/features/group.go (+10 -6)
📝 test/e2e/v1/features/store.go (+13 -14)

📄 Description

Summary

  • Replace 21 time.Sleep calls across chaos.go, group.go, and store.go with deterministic event-driven waiting
  • Add WaitForTCPUnreachable(addr, interval, timeout) helper for port closure detection
  • Add CountOutput(pattern) method for snapshot-based incremental log matching to avoid cumulative count races

Test plan

  • make e2e passed (225/225)
  • golangci-lint run clean
  • go build ./... clean

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/5231 **Author:** [@fatedier](https://github.com/fatedier) **Created:** 3/11/2026 **Status:** ✅ Merged **Merged:** 3/11/2026 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `new` --- ### 📝 Commits (2) - [`d4fe14e`](https://github.com/fatedier/frp/commit/d4fe14e78f5b0f0d7079795ff453ba6ad11d96a4) test/e2e: replace sleeps with event-driven waits in chaos/group/store tests - [`1316da0`](https://github.com/fatedier/frp/commit/1316da0832676c0c18ab82987f49115deb046d48) test/e2e: validate interval and cap dial/sleep to remaining deadline in WaitForTCPUnreachable ### 📊 Changes **5 files changed** (+57 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `test/e2e/framework/process.go` (+24 -0) 📝 `test/e2e/pkg/process/process.go` (+5 -0) 📝 `test/e2e/v1/features/chaos.go` (+5 -5) 📝 `test/e2e/v1/features/group.go` (+10 -6) 📝 `test/e2e/v1/features/store.go` (+13 -14) </details> ### 📄 Description ## Summary - Replace 21 `time.Sleep` calls across `chaos.go`, `group.go`, and `store.go` with deterministic event-driven waiting - Add `WaitForTCPUnreachable(addr, interval, timeout)` helper for port closure detection - Add `CountOutput(pattern)` method for snapshot-based incremental log matching to avoid cumulative count races ## Test plan - [x] `make e2e` passed (225/225) - [x] `golangci-lint run` clean - [x] `go build ./...` clean --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 14:56:26 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/frp#5193
No description provided.