[PR #5208] [MERGED] server/proxy: simplify HTTPS and TCPMux proxy domain registration #5175

Closed
opened 2026-05-05 14:56:08 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/5208
Author: @fatedier
Created: 3/6/2026
Status: Merged
Merged: 3/6/2026
Merged by: @fatedier

Base: devHead: new


📝 Commits (1)

  • a18cfda server/proxy: simplify HTTPS and TCPMux proxy domain registration

📊 Changes

2 files changed (+19 additions, -26 deletions)

View changed files

📝 server/proxy/https.go (+9 -14)
📝 server/proxy/tcpmux.go (+10 -12)

📄 Description

Summary

  • Apply the same domain consolidation pattern from #5207 to HTTPSProxy.Run() and TCPMuxProxy.httpConnectRun()
  • Replace separate custom-domain loop + subdomain block with a single unified loop over all domains
  • No behavioral change; build and vet pass

Context

Follow-up to #5207 which applied this simplification to HTTPProxy. The HTTPS and TCPMux proxies had the same duplicated pattern.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/5208 **Author:** [@fatedier](https://github.com/fatedier) **Created:** 3/6/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `new` --- ### 📝 Commits (1) - [`a18cfda`](https://github.com/fatedier/frp/commit/a18cfda81d39edb584e2183f219190ee910eb890) server/proxy: simplify HTTPS and TCPMux proxy domain registration ### 📊 Changes **2 files changed** (+19 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `server/proxy/https.go` (+9 -14) 📝 `server/proxy/tcpmux.go` (+10 -12) </details> ### 📄 Description ## Summary - Apply the same domain consolidation pattern from #5207 to `HTTPSProxy.Run()` and `TCPMuxProxy.httpConnectRun()` - Replace separate custom-domain loop + subdomain block with a single unified loop over all domains - No behavioral change; build and vet pass ## Context Follow-up to #5207 which applied this simplification to `HTTPProxy`. The HTTPS and TCPMux proxies had the same duplicated pattern. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 14:56:08 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/frp#5175
No description provided.