[PR #4985] [MERGED] add proxy name label to the proxy_count prometheus metric #5091

New issue

Closed

opened 2026-05-05 14:54:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:54:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/4985
Author: @charlieblevins
Created: 9/19/2025
Status: ✅ Merged
Merged: 9/22/2025
Merged by: @fatedier

Base: dev ← Head: patch/proxy-name-label

📝 Commits (5)

62626e2 add proxy name label to the proxy_count metric
c0b6318 undo label addition in favor of a new metric - this change should not break existing queries
7cfb0fb also register this new metric
06e44c5 add type label to proxy_counts_detailed
e2022d7 Update pkg/metrics/prometheus/server.go

📊 Changes

1 file changed (+17 additions, -7 deletions)

View changed files

📝 pkg/metrics/prometheus/server.go (+17 -7)

📄 Description

WHY

In my use case, I have many different frpc binaries connecting to the same frps binary. Each frpc binary has a unique proxy name configured.

For this reason, it is useful to know which proxy (i.e. worker/control connection) is active. Without this PR, I can only know how many proxies are connected, but not which ones.

Fix #4986

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/4985 **Author:** [@charlieblevins](https://github.com/charlieblevins) **Created:** 9/19/2025 **Status:** ✅ Merged **Merged:** 9/22/2025 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `patch/proxy-name-label` --- ### 📝 Commits (5) - [`62626e2`](https://github.com/fatedier/frp/commit/62626e2770b4144262fa3ecac5c8ab3b871868dd) add proxy name label to the proxy_count metric - [`c0b6318`](https://github.com/fatedier/frp/commit/c0b6318eddcbe6073d80db48dcd8931b6798354d) undo label addition in favor of a new metric - this change should not break existing queries - [`7cfb0fb`](https://github.com/fatedier/frp/commit/7cfb0fbe32da1245792d05290b756e370ff24563) also register this new metric - [`06e44c5`](https://github.com/fatedier/frp/commit/06e44c58409a0edd02d664e5cf1eeaedee24d0e2) add type label to proxy_counts_detailed - [`e2022d7`](https://github.com/fatedier/frp/commit/e2022d7e8b640f9a1391ed43a91e4bd73b6a561d) Update pkg/metrics/prometheus/server.go ### 📊 Changes **1 file changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/metrics/prometheus/server.go` (+17 -7) </details> ### 📄 Description ### WHY In my use case, I have many different frpc binaries connecting to the same frps binary. Each frpc binary has a unique proxy name configured. For this reason, it is useful to know which proxy (i.e. worker/control connection) is active. Without this PR, I can only know how many proxies are connected, but not which ones. Fix #4986 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>