[PR #4979] [CLOSED] resolve shellcheck warnings #5089

New issue

Closed

opened 2026-05-05 14:54:32 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:54:32 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/4979
Author: @TheKhanj
Created: 9/15/2025
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (1)

dc0bd9d resolve shellcheck warnings

📊 Changes

2 files changed (+21 additions, -22 deletions)

View changed files

📝 hack/run-e2e.sh (+2 -2)
📝 package.sh (+19 -20)

📄 Description

I’m not sure which shells you want to support, but for now ShellCheck supports sh, bash, dash, and ksh, and it was complaining about these issues. It doesn’t support zsh, ash, csh, or others—but most of its complaints are pretty reasonable (though you could definitely argue about that x-prefixing thing 🤷).

It’s a minor thing, I know… but I wanted to familiarize myself with the project a bit—and since I was already using a couple of these files in my own projects (not sure if I even have the permission to do that 🫣), I figured I’d fix them here too :). Feel free to ignore the pull request if it doesn’t fit.

Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. (shellcheck SC2181)
https://www.shellcheck.net/wiki/SC2181

Use $(...) notation instead of legacy backticks .... (shellcheck SC2006)
https://www.shellcheck.net/wiki/SC2006

Avoid x-prefix in comparisons as it no longer serves a purpose. (shellcheck SC2268) https://www.shellcheck.net/wiki/SC2268

Double quote to prevent globbing and word splitting.
(shellcheck SC2086)
https://www.shellcheck.net/wiki/SC2086

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/4979 **Author:** [@TheKhanj](https://github.com/TheKhanj) **Created:** 9/15/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`dc0bd9d`](https://github.com/fatedier/frp/commit/dc0bd9d3f61a35551c8b23fb8fa24b47439a5670) resolve shellcheck warnings ### 📊 Changes **2 files changed** (+21 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `hack/run-e2e.sh` (+2 -2) 📝 `package.sh` (+19 -20) </details> ### 📄 Description I’m not sure which shells you want to support, but for now ShellCheck supports sh, bash, dash, and ksh, and it was complaining about these issues. It doesn’t support zsh, ash, csh, or others—but most of its complaints are pretty reasonable (though you could definitely argue about that x-prefixing thing 🤷). It’s a minor thing, I know… but I wanted to familiarize myself with the project a bit—and since I was already using a couple of these files in my own projects (not sure if I even have the permission to do that 🫣), I figured I’d fix them here too :). Feel free to ignore the pull request if it doesn’t fit. Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?. (shellcheck SC2181) https://www.shellcheck.net/wiki/SC2181 Use $(...) notation instead of legacy backticks `...`. (shellcheck SC2006) https://www.shellcheck.net/wiki/SC2006 Avoid x-prefix in comparisons as it no longer serves a purpose. (shellcheck SC2268) https://www.shellcheck.net/wiki/SC2268 Double quote to prevent globbing and word splitting. (shellcheck SC2086) https://www.shellcheck.net/wiki/SC2086 Double quote to prevent globbing and word splitting. (shellcheck SC2086) https://www.shellcheck.net/wiki/SC2086 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>