[PR #4176] [MERGED] Makefile.cross-compiles: Fix softfloat flag not being honored for mipsle #4938

Closed
opened 2026-05-05 14:51:36 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/4176
Author: @ddscentral
Created: 4/22/2024
Status: Merged
Merged: 4/22/2024
Merged by: @fatedier

Base: devHead: dev


📝 Commits (1)

  • 17c7c1c Makefile.cross-compiles: Fix softfloat flag not being honored for mipsle.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Makefile.cross-compiles (+1 -1)

📄 Description

WHY

When building using Makefile.cross-compiles, softfloat flag was being applied only to "mips" big-endian builds but not "mipsle" little-endian builds despite the flag being set in architecture list. This resulted in binaries which would not run on target machines without a FPU or a FPU emulator in kernel.
This change fixes the "if" statement in Makefile.cross-compiles to correctly apply the softfloat flag to both "mips" and "mipsle" builds.

Binaries run fine on a system with a BCM4706 MIPS SoC.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/4176 **Author:** [@ddscentral](https://github.com/ddscentral) **Created:** 4/22/2024 **Status:** ✅ Merged **Merged:** 4/22/2024 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`17c7c1c`](https://github.com/fatedier/frp/commit/17c7c1cccd2cd8d02d9ef8830734119f4b33e488) Makefile.cross-compiles: Fix softfloat flag not being honored for mipsle. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Makefile.cross-compiles` (+1 -1) </details> ### 📄 Description ### WHY When building using Makefile.cross-compiles, softfloat flag was being applied only to "mips" big-endian builds but not "mipsle" little-endian builds despite the flag being set in architecture list. This resulted in binaries which would not run on target machines without a FPU or a FPU emulator in kernel. This change fixes the "if" statement in Makefile.cross-compiles to correctly apply the softfloat flag to both "mips" and "mipsle" builds. Binaries run fine on a system with a BCM4706 MIPS SoC. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 14:51:36 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/frp#4938
No description provided.