[PR #4149] [MERGED] fix: revert gorilla/websocket from 1.5.1 to 1.5.0 #4929

New issue

Closed

opened 2026-05-05 14:51:28 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:51:28 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/4149
Author: @wlynxg
Created: 4/11/2024
Status: ✅ Merged
Merged: 4/11/2024
Merged by: @fatedier

Base: dev ← Head: dev

📝 Commits (1)

e1a91c9 fix: revert gorilla/websocket from 1.5.1 to 1.5.0

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 go.mod (+1 -1)
📝 go.sum (+2 -2)

📄 Description

WHY

gorilla/websocket 1.5.1 is a problematic version.
There will be a lot of logs about websocket because they use log.Prinf directly in the code to print errors. For details, see: https://github.com/gorilla/websocket/issues/880

And websocket 1.5.1 seems to have changed some other features that should not be added. I think frp should roll back the websocket version to 1.5.0 to avoid these problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/4149 **Author:** [@wlynxg](https://github.com/wlynxg) **Created:** 4/11/2024 **Status:** ✅ Merged **Merged:** 4/11/2024 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`e1a91c9`](https://github.com/fatedier/frp/commit/e1a91c97a195240bb5f62e5f3abc18b742dfa557) fix: revert gorilla/websocket from 1.5.1 to 1.5.0 ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+1 -1) 📝 `go.sum` (+2 -2) </details> ### 📄 Description ### WHY gorilla/websocket 1.5.1 is a problematic version. There will be a lot of logs about websocket because they use `log.Prinf` directly in the code to print errors. For details, see: https://github.com/gorilla/websocket/issues/880 And websocket 1.5.1 seems to have changed some other features that should not be added. I think frp should roll back the websocket version to 1.5.0 to avoid these problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>