[PR #3871] [MERGED] fix(backoff): close of closed out channel #4851

New issue

Closed

opened 2026-05-05 14:49:58 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:49:58 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/3871
Author: @wuqinqiang
Created: 12/21/2023
Status: ✅ Merged
Merged: 12/21/2023
Merged by: @fatedier

Base: dev ← Head: fix/backoff

📝 Commits (2)

8adf35d fix: close of closed channel
61438cb feat: replace Try0 to std

📊 Changes

1 file changed (+7 additions, -6 deletions)

View changed files

📝 pkg/util/wait/backoff.go (+7 -6)

📄 Description

WHY

currently, MergeAndCloseOnAnyStopChannel may repeatedly call close out chan multiple times. even if Try0 recovered the panic. we should make sure that only once

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/3871 **Author:** [@wuqinqiang](https://github.com/wuqinqiang) **Created:** 12/21/2023 **Status:** ✅ Merged **Merged:** 12/21/2023 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `fix/backoff` --- ### 📝 Commits (2) - [`8adf35d`](https://github.com/fatedier/frp/commit/8adf35d48059647c6f93e47d2431b8c7884a6735) fix: close of closed channel - [`61438cb`](https://github.com/fatedier/frp/commit/61438cb955505d6c22e98745c796617aab71bfcc) feat: replace Try0 to std ### 📊 Changes **1 file changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkg/util/wait/backoff.go` (+7 -6) </details> ### 📄 Description ### WHY currently, MergeAndCloseOnAnyStopChannel may repeatedly call close out chan multiple times. even if Try0 recovered the panic. we should make sure that only once --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>