[PR #2853] [CLOSED] Golangci-lint integration #4641

New issue

Closed

opened 2026-05-05 14:45:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:45:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/2853
Author: @dzyanis
Created: 3/17/2022
Status: ❌ Closed

Base: dev ← Head: golangci-lint

📝 Commits (9)

7abbf51 add golangci-lint config
70fb6d3 fix gocritic linter warnings
18c38d1 fixed govet issues
8e69e24 fixed gofmt issue
74e2878 fix forgotten close body
0026a99 fixed misspellings
2cc3b11 improve goimport format
b229af9 fixed ineffectual assignment
cf65e85 fixed errors formatting

📊 Changes

79 files changed (+386 additions, -258 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ .golangci.yml (+118 -0)
📝 client/admin.go (+2 -2)
📝 client/control.go (+7 -6)
📝 client/proxy/proxy.go (+11 -11)
📝 client/proxy/proxy_manager.go (+4 -6)
📝 client/proxy/proxy_wrapper.go (+2 -2)
📝 client/service.go (+4 -4)
📝 client/visitor.go (+11 -11)
📝 client/visitor_manager.go (+2 -4)
📝 cmd/frpc/main.go (+2 -2)
📝 cmd/frpc/sub/http.go (+2 -2)
📝 cmd/frpc/sub/reload.go (+2 -2)
📝 cmd/frpc/sub/root.go (+8 -6)
📝 cmd/frpc/sub/status.go (+3 -3)
📝 cmd/frpc/sub/stcp.go (+2 -2)
📝 cmd/frpc/sub/sudp.go (+2 -2)
📝 cmd/frpc/sub/udp.go (+2 -2)
📝 cmd/frpc/sub/verify.go (+2 -2)
📝 cmd/frpc/sub/xtcp.go (+2 -2)

...and 59 more files

📄 Description

I'd recommend to integrate golangci-lint and then enable linters one by one

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/2853 **Author:** [@dzyanis](https://github.com/dzyanis) **Created:** 3/17/2022 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `golangci-lint` --- ### 📝 Commits (9) - [`7abbf51`](https://github.com/fatedier/frp/commit/7abbf5188da9a3df50d56e27f7618b04b87b18fd) add golangci-lint config - [`70fb6d3`](https://github.com/fatedier/frp/commit/70fb6d396dd7a6c3838b4453d4b732193e61dbfc) fix gocritic linter warnings - [`18c38d1`](https://github.com/fatedier/frp/commit/18c38d1fb01775e179d555ea136150a978afce87) fixed govet issues - [`8e69e24`](https://github.com/fatedier/frp/commit/8e69e2423f1e526853bd70e88ace98bfcb966903) fixed gofmt issue - [`74e2878`](https://github.com/fatedier/frp/commit/74e28788e62ed4fdcd068833e94d31dd36f728a7) fix forgotten close body - [`0026a99`](https://github.com/fatedier/frp/commit/0026a99e2f2c560bfdecf0284cd881406aa688fe) fixed misspellings - [`2cc3b11`](https://github.com/fatedier/frp/commit/2cc3b11e0fefe63da68ff56885f5056ba3875d57) improve goimport format - [`b229af9`](https://github.com/fatedier/frp/commit/b229af96070f0d72cd0f2979713d6c2162dc08aa) fixed ineffectual assignment - [`cf65e85`](https://github.com/fatedier/frp/commit/cf65e85b936c35f0c1f46e0b7e901946da2d22f0) fixed errors formatting ### 📊 Changes **79 files changed** (+386 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `.golangci.yml` (+118 -0) 📝 `client/admin.go` (+2 -2) 📝 `client/control.go` (+7 -6) 📝 `client/proxy/proxy.go` (+11 -11) 📝 `client/proxy/proxy_manager.go` (+4 -6) 📝 `client/proxy/proxy_wrapper.go` (+2 -2) 📝 `client/service.go` (+4 -4) 📝 `client/visitor.go` (+11 -11) 📝 `client/visitor_manager.go` (+2 -4) 📝 `cmd/frpc/main.go` (+2 -2) 📝 `cmd/frpc/sub/http.go` (+2 -2) 📝 `cmd/frpc/sub/reload.go` (+2 -2) 📝 `cmd/frpc/sub/root.go` (+8 -6) 📝 `cmd/frpc/sub/status.go` (+3 -3) 📝 `cmd/frpc/sub/stcp.go` (+2 -2) 📝 `cmd/frpc/sub/sudp.go` (+2 -2) 📝 `cmd/frpc/sub/udp.go` (+2 -2) 📝 `cmd/frpc/sub/verify.go` (+2 -2) 📝 `cmd/frpc/sub/xtcp.go` (+2 -2) _...and 59 more files_ </details> ### 📄 Description I'd recommend to integrate [golangci-lint](https://golangci-lint.run/) and then enable linters one by one --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>