[PR #2856] [CLOSED] Golangci-lint #4640

New issue

Closed

opened 2026-05-05 14:45:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:45:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/2856
Author: @dzyanis
Created: 3/18/2022
Status: ❌ Closed

Base: dev ← Head: golangci-lint

📝 Commits (10+)

6451583 Merge pull request #1349 from fatedier/dev
ae08811 Merge pull request #1364 from fatedier/dev
134a46c Merge pull request #1369 from fatedier/dev
e62d9a5 Merge pull request #1415 from fatedier/dev
adc3adc Merge pull request #1494 from fatedier/dev
75f3bce Merge pull request #1542 from fatedier/dev
30c246c Merge pull request #1588 from fatedier/dev
f480160 Merge pull request #1596 from fatedier/dev
487c8d7 Merge pull request #1637 from fatedier/dev
23bb763 Merge pull request #1696 from fatedier/dev

📊 Changes

3 files changed (+131 additions, -0 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ .golangci.yml (+124 -0)
📝 Makefile (+6 -0)

📄 Description

There are many issues with formatting, misspellings and even potentially dangerous bugs.
Even standard go vet returns two warnings:

$ go vet ./...
# github.com/fatedier/frp/test/e2e/plugin
test/e2e/plugin/server.go:148:18: Sprintf call needs 1 arg but has 2 args
# github.com/fatedier/frp/cmd/frpc/sub
cmd/frpc/sub/root.go:125:2: misuse of unbuffered os.Signal channel as argument to signal.Notify

I'd recommend to integrate golngci-lint and then enable linters one by one.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/2856 **Author:** [@dzyanis](https://github.com/dzyanis) **Created:** 3/18/2022 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `golangci-lint` --- ### 📝 Commits (10+) - [`6451583`](https://github.com/fatedier/frp/commit/6451583e60184a90c274f6683a44e89fb7a9118e) Merge pull request #1349 from fatedier/dev - [`ae08811`](https://github.com/fatedier/frp/commit/ae08811636f6ab449deb30cf7579390f9d476ab3) Merge pull request #1364 from fatedier/dev - [`134a46c`](https://github.com/fatedier/frp/commit/134a46c00b59a641dc89ab9265ea73d2d7aa6ff2) Merge pull request #1369 from fatedier/dev - [`e62d9a5`](https://github.com/fatedier/frp/commit/e62d9a52429f54dee8df1c42f2d4bad7a267b05d) Merge pull request #1415 from fatedier/dev - [`adc3adc`](https://github.com/fatedier/frp/commit/adc3adc13bf3a2bc43354377b842944f9cfc6a25) Merge pull request #1494 from fatedier/dev - [`75f3bce`](https://github.com/fatedier/frp/commit/75f3bce04dad71213fbf63da2dd6000a22e2c431) Merge pull request #1542 from fatedier/dev - [`30c246c`](https://github.com/fatedier/frp/commit/30c246c48889140402943f5aebb04c89b031c708) Merge pull request #1588 from fatedier/dev - [`f480160`](https://github.com/fatedier/frp/commit/f480160e2d22b9bbca2590660b50d69a1c5059bc) Merge pull request #1596 from fatedier/dev - [`487c8d7`](https://github.com/fatedier/frp/commit/487c8d7c29b3bbedbd0351029c480d30a7c2d880) Merge pull request #1637 from fatedier/dev - [`23bb763`](https://github.com/fatedier/frp/commit/23bb76397a0484485a16e1a3e990385b13ee388d) Merge pull request #1696 from fatedier/dev ### 📊 Changes **3 files changed** (+131 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `.golangci.yml` (+124 -0) 📝 `Makefile` (+6 -0) </details> ### 📄 Description There are many issues with formatting, misspellings and even potentially dangerous bugs. Even standard `go vet` returns two warnings: ```bash $ go vet ./... # github.com/fatedier/frp/test/e2e/plugin test/e2e/plugin/server.go:148:18: Sprintf call needs 1 arg but has 2 args # github.com/fatedier/frp/cmd/frpc/sub cmd/frpc/sub/root.go:125:2: misuse of unbuffered os.Signal channel as argument to signal.Notify ``` I'd recommend to integrate [golngci-lint](https://golangci-lint.run/) and then enable linters one by one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>