[PR #2255] [MERGED] Let's get rid of ugly statik #4537

New issue

Closed

opened 2026-05-05 14:43:56 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:43:56 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/2255
Author: @fakeboboliu
Created: 2/23/2021
Status: ✅ Merged
Merged: 8/17/2021
Merged by: @fatedier

Base: dev ← Head: dev

📝 Commits (3)

f773f85 Get rid of ugly statik
2361d62 remove statik totally
58c2e16 split go and static files in assets

📊 Changes

12 files changed (+43 additions, -77 deletions)

View changed files

📝 Makefile (+0 -3)
📝 assets/assets.go (+10 -39)
➕ assets/frpc/embed.go (+14 -0)
➖ assets/frpc/statik/statik.go (+0 -10)
➕ assets/frps/embed.go (+14 -0)
➖ assets/frps/statik/statik.go (+0 -10)
📝 client/service.go (+2 -5)
📝 cmd/frpc/main.go (+1 -1)
📝 cmd/frps/main.go (+1 -1)
📝 go.mod (+0 -1)
📝 go.sum (+0 -2)
📝 server/service.go (+1 -5)

📄 Description

Intro

go1.16 introduced the embed package, it's the more graceful solution for embedding file into binary.
https://golang.org/pkg/embed/

Pros

The code itself is more graceful
It makes the binary smaller slightly

(Even with upx packed)

Oh that's sweet, what's the cost?

Use go1.16, well i'm changed ci configurations already

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/2255 **Author:** [@fakeboboliu](https://github.com/fakeboboliu) **Created:** 2/23/2021 **Status:** ✅ Merged **Merged:** 8/17/2021 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (3) - [`f773f85`](https://github.com/fatedier/frp/commit/f773f85f8ad7d14ae3e9781cfec90901a2b08e2b) Get rid of ugly statik - [`2361d62`](https://github.com/fatedier/frp/commit/2361d62134151d33d255e460cb0208ff2f60105a) remove statik totally - [`58c2e16`](https://github.com/fatedier/frp/commit/58c2e1670502edbcf13e8a98cf0bbe7b03419a4f) split go and static files in assets ### 📊 Changes **12 files changed** (+43 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+0 -3) 📝 `assets/assets.go` (+10 -39) ➕ `assets/frpc/embed.go` (+14 -0) ➖ `assets/frpc/statik/statik.go` (+0 -10) ➕ `assets/frps/embed.go` (+14 -0) ➖ `assets/frps/statik/statik.go` (+0 -10) 📝 `client/service.go` (+2 -5) 📝 `cmd/frpc/main.go` (+1 -1) 📝 `cmd/frps/main.go` (+1 -1) 📝 `go.mod` (+0 -1) 📝 `go.sum` (+0 -2) 📝 `server/service.go` (+1 -5) </details> ### 📄 Description ## Intro go1.16 introduced the embed package, it's the more graceful solution for embedding file into binary. https://golang.org/pkg/embed/ ## Pros - The code itself is more graceful - It makes the binary smaller slightly ![image](https://user-images.githubusercontent.com/7552030/108883722-c466fb80-7640-11eb-8996-a8b1fa4adc58.png) (Even with upx packed) ## Oh that's sweet, what's the cost? Use go1.16, well i'm changed ci configurations already --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>