mirror of
https://github.com/fatedier/frp.git
synced 2026-05-15 08:05:49 -06:00
[PR #1408] [MERGED] Add documentation for common configuration fields, common proxy configuration, and sessions #4380
Labels
No labels
In Progress
WIP
WaitingForInfo
bug
doc
duplicate
easy
enhancement
future
help wanted
invalid
lifecycle/stale
need-issue-template
need-usage-help
no plan
proposal
pull-request
question
todo
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/frp#4380
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/fatedier/frp/pull/1408
Author: @velovix
Created: 8/24/2019
Status: ✅ Merged
Merged: 8/25/2019
Merged by: @fatedier
Base:
dev← Head:issue-1387_api-documentation📝 Commits (2)
4dfd851Add docs for common config fields & sessions9279126Add documentation for base proxy config📊 Changes
4 files changed (+261 additions, -73 deletions)
View changed files
📝
client/service.go(+2 -0)📝
models/config/client_common.go(+93 -27)📝
models/config/proxy.go(+64 -20)📝
models/config/server_common.go(+102 -26)📄 Description
Now that the common configuration objects and session objects are part of a public API, they need to be documented in a way that can be read with GoDoc.
This documentation is not yet complete on the client side. I still need to write documentation for the specific proxy objects like TcpProxyConf and HttpProxyConf, but I figured this was enough to review for one pull request.
I documented these fields to the best of my ability but I'm sure I got some details wrong. Please let me know what I can clarify and improve.
Related: #1387
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.