[PR #1395] [MERGED] Load assets for dashboard/admin panel on demand #4375

New issue

Closed

opened 2026-05-05 14:40:54 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:40:54 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/1395
Author: @velovix
Created: 8/19/2019
Status: ✅ Merged
Merged: 8/20/2019
Merged by: @fatedier

Base: dev ← Head: issue-1387_load-assets-on-demand

📝 Commits (1)

00bd0a8 Load assets for dashboard/admin panel on demand

📊 Changes

2 files changed (+14 additions, -15 deletions)

View changed files

📝 client/service.go (+7 -8)
📝 server/service.go (+7 -7)

📄 Description

(This PR contains the same changes as #1391, but now is based off the dev branch instead of master)

The client and server services now only attempt to load assets if the dashboard or admin panel are enabled. This change makes it possible to use FRP as a library without having to manage assets.

If a library user wants to start a server with the dashboard enabled, they will need to set the DashboardPort and AssetsDir fields of ServerCommonConf.

If a library use wants to start a client with the admin panel enabled, that isn't currently possible because there's no way to customize the admin panel's assets directory. I can send a PR for that as well if there's interest.

Related: #1387

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/1395 **Author:** [@velovix](https://github.com/velovix) **Created:** 8/19/2019 **Status:** ✅ Merged **Merged:** 8/20/2019 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `issue-1387_load-assets-on-demand` --- ### 📝 Commits (1) - [`00bd0a8`](https://github.com/fatedier/frp/commit/00bd0a8af4f1365d114484ee2ed1c47417c8d450) Load assets for dashboard/admin panel on demand ### 📊 Changes **2 files changed** (+14 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `client/service.go` (+7 -8) 📝 `server/service.go` (+7 -7) </details> ### 📄 Description (This PR contains the same changes as #1391, but now is based off the dev branch instead of master) The client and server services now only attempt to load assets if the dashboard or admin panel are enabled. This change makes it possible to use FRP as a library without having to manage assets. If a library user wants to start a server with the dashboard enabled, they will need to set the DashboardPort and AssetsDir fields of ServerCommonConf. If a library use wants to start a client with the admin panel enabled, that isn't currently possible because there's no way to customize the admin panel's assets directory. I can send a PR for that as well if there's interest. Related: #1387 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>