mirror of
https://github.com/fatedier/frp.git
synced 2026-05-15 08:05:49 -06:00
[PR #1391] [CLOSED] Load assets for dashboard/admin panel on demand #4372
Labels
No labels
In Progress
WIP
WaitingForInfo
bug
doc
duplicate
easy
enhancement
future
help wanted
invalid
lifecycle/stale
need-issue-template
need-usage-help
no plan
proposal
pull-request
question
todo
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/frp#4372
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/fatedier/frp/pull/1391
Author: @velovix
Created: 8/16/2019
Status: ❌ Closed
Base:
master← Head:issue-1387_load-assets-on-demand📝 Commits (1)
d730fd8Load assets for dashboard/admin panel on demand📊 Changes
2 files changed (+14 additions, -15 deletions)
View changed files
📝
client/service.go(+7 -8)📝
server/service.go(+7 -7)📄 Description
The client and server services now only attempt to load assets if the dashboard or admin panel are enabled. This change makes it possible to use FRP as a library without having to manage assets.
If a library user wants to start a server with the dashboard enabled, they will need to set the DashboardPort and AssetsDir fields of ServerCommonConf.
If a library use wants to start a client with the admin panel enabled, that isn't currently possible because there's no way to customize the admin panel's assets directory. I can send a PR for that as well if there's interest.
Related: #1387
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.