[PR #1391] [CLOSED] Load assets for dashboard/admin panel on demand #4372

Closed
opened 2026-05-05 14:40:50 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/1391
Author: @velovix
Created: 8/16/2019
Status: Closed

Base: masterHead: issue-1387_load-assets-on-demand


📝 Commits (1)

  • d730fd8 Load assets for dashboard/admin panel on demand

📊 Changes

2 files changed (+14 additions, -15 deletions)

View changed files

📝 client/service.go (+7 -8)
📝 server/service.go (+7 -7)

📄 Description

The client and server services now only attempt to load assets if the dashboard or admin panel are enabled. This change makes it possible to use FRP as a library without having to manage assets.

If a library user wants to start a server with the dashboard enabled, they will need to set the DashboardPort and AssetsDir fields of ServerCommonConf.

If a library use wants to start a client with the admin panel enabled, that isn't currently possible because there's no way to customize the admin panel's assets directory. I can send a PR for that as well if there's interest.

Related: #1387


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/1391 **Author:** [@velovix](https://github.com/velovix) **Created:** 8/16/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `issue-1387_load-assets-on-demand` --- ### 📝 Commits (1) - [`d730fd8`](https://github.com/fatedier/frp/commit/d730fd82e054bb47722e74695c53e57a0924d7e9) Load assets for dashboard/admin panel on demand ### 📊 Changes **2 files changed** (+14 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `client/service.go` (+7 -8) 📝 `server/service.go` (+7 -7) </details> ### 📄 Description The client and server services now only attempt to load assets if the dashboard or admin panel are enabled. This change makes it possible to use FRP as a library without having to manage assets. If a library user wants to start a server with the dashboard enabled, they will need to set the DashboardPort and AssetsDir fields of ServerCommonConf. If a library use wants to start a client with the admin panel enabled, that isn't currently possible because there's no way to customize the admin panel's assets directory. I can send a PR for that as well if there's interest. Related: #1387 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 14:40:50 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/frp#4372
No description provided.