[PR #1271] [MERGED] resp.Body must be closed after function return #4348

New issue

Closed

opened 2026-05-05 14:40:20 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 14:40:20 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/1271
Author: @jiajunhuang
Created: 5/30/2019
Status: ✅ Merged
Merged: 5/31/2019
Merged by: @fatedier

Base: dev ← Head: resp_body_should_be_closed

📝 Commits (2)

75383a9 resp.Body must be closed after function return
2d24879 fix

📊 Changes

4 files changed (+134 additions, -118 deletions)

View changed files

📝 cmd/frpc/sub/reload.go (+10 -11)
📝 cmd/frpc/sub/status.go (+65 -63)
📝 go.sum (+15 -0)
📝 tests/util/util.go (+44 -44)

📄 Description

whether it's success or fail, otherwise it will cause memory leak
ref: https://golang.org/pkg/net/http/

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/1271 **Author:** [@jiajunhuang](https://github.com/jiajunhuang) **Created:** 5/30/2019 **Status:** ✅ Merged **Merged:** 5/31/2019 **Merged by:** [@fatedier](https://github.com/fatedier) **Base:** `dev` ← **Head:** `resp_body_should_be_closed` --- ### 📝 Commits (2) - [`75383a9`](https://github.com/fatedier/frp/commit/75383a95b360d3ed05b946800c627488e6a1fefc) resp.Body must be closed after function return - [`2d24879`](https://github.com/fatedier/frp/commit/2d24879fa37388e44b48955bff9ace25c9ec8bc6) fix ### 📊 Changes **4 files changed** (+134 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `cmd/frpc/sub/reload.go` (+10 -11) 📝 `cmd/frpc/sub/status.go` (+65 -63) 📝 `go.sum` (+15 -0) 📝 `tests/util/util.go` (+44 -44) </details> ### 📄 Description whether it's success or fail, otherwise it will cause memory leak ref: https://golang.org/pkg/net/http/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>