[PR #1269] [CLOSED] resp.Body must be closed after function return #4347

Closed
opened 2026-05-05 14:40:19 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/fatedier/frp/pull/1269
Author: @jiajunhuang
Created: 5/30/2019
Status: Closed

Base: masterHead: resp_body_must_be_closed


📝 Commits (2)

  • 6e9de3e resp.Body must be closed after function return
  • 00ea825 update go.sum

📊 Changes

4 files changed (+133 additions, -118 deletions)

View changed files

📝 cmd/frpc/sub/reload.go (+10 -11)
📝 cmd/frpc/sub/status.go (+64 -63)
📝 go.sum (+15 -0)
📝 tests/util/util.go (+44 -44)

📄 Description

whether it's success or fail, otherwise it will cause memory leak
ref: https://golang.org/pkg/net/http/


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fatedier/frp/pull/1269 **Author:** [@jiajunhuang](https://github.com/jiajunhuang) **Created:** 5/30/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `resp_body_must_be_closed` --- ### 📝 Commits (2) - [`6e9de3e`](https://github.com/fatedier/frp/commit/6e9de3e3b8c30c753e07cb11e48295cf4597c7b7) resp.Body must be closed after function return - [`00ea825`](https://github.com/fatedier/frp/commit/00ea8256a7cff6f4208639fc7d12eb5cb59f1562) update go.sum ### 📊 Changes **4 files changed** (+133 additions, -118 deletions) <details> <summary>View changed files</summary> 📝 `cmd/frpc/sub/reload.go` (+10 -11) 📝 `cmd/frpc/sub/status.go` (+64 -63) 📝 `go.sum` (+15 -0) 📝 `tests/util/util.go` (+44 -44) </details> ### 📄 Description whether it's success or fail, otherwise it will cause memory leak ref: https://golang.org/pkg/net/http/ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 14:40:19 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/frp#4347
No description provided.