[GH-ISSUE #4175] mipsle arch is missing softfloat flag due to Makefile.cross-compiles bug #3289

Closed
opened 2026-05-05 14:07:22 -06:00 by gitea-mirror · 3 comments
Owner

Originally created by @ddscentral on GitHub (Apr 22, 2024).
Original GitHub issue: https://github.com/fatedier/frp/issues/4175

Bug Description

In Makefile.cross-compiles even though both mips and mipsle have softfloat flag, it is only applied for "mips" due to a bug in "if statement.

Line

 elif [ "$${os}" = "linux" ] && [ "$${arch}" = "mips" ] && [ "$${extra}" != "" ] ; then \

should look like this:

 elif [ "$${os}" = "linux" ] && ([ "$${arch}" = "mips" ] || [ "$${arch}" = "mipsle" ]) && [ "$${extra}" != "" ] ; then \

frpc Version

0.57.0

frps Version

0.57.0

System Architecture

linux/mipsel

Configurations

Not applicable

Logs

No response

Steps to reproduce

  1. Run make -f Makefile.cross-compiles
  2. Copy mipsle binary (any frps or frpc) to a MIPS device without a FPU
  3. Binary does not run due to "illegal instruction".

Affected area

  • Docs
  • Installation
  • Performance and Scalability
  • Security
  • User Experience
  • Test and Release
  • Developer Infrastructure
  • Client Plugin
  • Server Plugin
  • Extensions
  • Others
Originally created by @ddscentral on GitHub (Apr 22, 2024). Original GitHub issue: https://github.com/fatedier/frp/issues/4175 ### Bug Description In Makefile.cross-compiles even though both mips and mipsle have softfloat flag, it is only applied for "mips" due to a bug in "if statement. Line ``` elif [ "$${os}" = "linux" ] && [ "$${arch}" = "mips" ] && [ "$${extra}" != "" ] ; then \ ``` should look like this: ``` elif [ "$${os}" = "linux" ] && ([ "$${arch}" = "mips" ] || [ "$${arch}" = "mipsle" ]) && [ "$${extra}" != "" ] ; then \ ``` ### frpc Version 0.57.0 ### frps Version 0.57.0 ### System Architecture linux/mipsel ### Configurations Not applicable ### Logs _No response_ ### Steps to reproduce 1. Run make -f Makefile.cross-compiles 2. Copy mipsle binary (any frps or frpc) to a MIPS device without a FPU 3. Binary does not run due to "illegal instruction". ### Affected area - [ ] Docs - [X] Installation - [ ] Performance and Scalability - [ ] Security - [ ] User Experience - [X] Test and Release - [ ] Developer Infrastructure - [ ] Client Plugin - [ ] Server Plugin - [ ] Extensions - [X] Others
gitea-mirror 2026-05-05 14:07:22 -06:00
  • closed this issue
  • added the
    todo
    label
Author
Owner

@ddscentral commented on GitHub (Apr 22, 2024):

With the line corrected, binaries do run on the device.

<!-- gh-comment-id:2068812808 --> @ddscentral commented on GitHub (Apr 22, 2024): With the line corrected, binaries do run on the device.
Author
Owner

@fatedier commented on GitHub (Apr 22, 2024):

Can you submit a PR to fix it?

<!-- gh-comment-id:2068820657 --> @fatedier commented on GitHub (Apr 22, 2024): Can you submit a PR to fix it?
Author
Owner

@ddscentral commented on GitHub (Apr 22, 2024):

Created a PR: https://github.com/fatedier/frp/pull/4176

<!-- gh-comment-id:2069012027 --> @ddscentral commented on GitHub (Apr 22, 2024): Created a PR: https://github.com/fatedier/frp/pull/4176
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/frp#3289
No description provided.