mirror of
https://github.com/fatedier/frp.git
synced 2026-05-15 08:05:49 -06:00
[GH-ISSUE #3478] [Feature Request] Dockerfile & docker-entrypoint.sh #2780
Labels
No labels
In Progress
WIP
WaitingForInfo
bug
doc
duplicate
easy
enhancement
future
help wanted
invalid
lifecycle/stale
need-issue-template
need-usage-help
no plan
proposal
pull-request
question
todo
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/frp#2780
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Zhou-Tx on GitHub (Jun 5, 2023).
Original GitHub issue: https://github.com/fatedier/frp/issues/3478
Describe the feature request
I would like to create a release version of frps on docker(maybe frpc can be built as well), for more and more users need to run this application on cloud-native environment.
Describe alternatives you've considered
As we know, docker container is a single-process model, thus we can put frps into a container and run with custom arguments.
Firstly, create a
docker-entrypoint.shto load custom arguments and startup frps application;secondly, generate a multi-platform
Dockerfileto build images for different os/arch, and we may push these images to docker hub.Affected area
@Zhou-Tx commented on GitHub (Jun 5, 2023):
I saw there is a directory named
dockerfileswhich containsDockerfile-for-frpsandDockerfile-for-frpc, but I think that it can only build a executable file but cannot startup conveniently, so I would like to create adocker-entrypoint.shto simplify the process when starting, loading custom startup parameter included.@fatedier commented on GitHub (Jun 6, 2023):
You can check the Docker official documentation to learn how to use custom commands to start a container.
@Zhou-Tx commented on GitHub (Jun 6, 2023):
Excuse me, perhaps I didn't describe the appeal clearly. I would like to optimize the
Dockerfileand publish to docker hub officially, since there isn't a unified platform standard image.@Becods commented on GitHub (Jun 6, 2023):
Usually the user only needs to specify the frp configuration file, and then almost all the configuration is edited in the configuration file.
So you can start frp with a simple command :
docker run -it `pwd`/frpc.ini:/frpc.ini fatedier/frpc:v0.49.0 -c /frpc.iniIt seems to me that starting frp via entrypoint.sh is an unnecessary operation.
da51adc276/.github/workflows/build-and-push-image.yml (L67-L68)@Zhou-Tx commented on GitHub (Jun 6, 2023):
All right, it's my fault that I didn't found the image
fatedier/frpcfor it has not been ranked first on DockerHub https://hub.docker.com/search?q=frpsP.s. What I was originally thinking was that using command line to starup frps instead of an ini file, and you are right that starting frp via entrypoint.sh is an unnecessary operation even though using command line arguments.
Thanks a lot.