mirror of
https://github.com/fatedier/frp.git
synced 2026-05-15 08:05:49 -06:00
[GH-ISSUE #2670] [Feature Request] Stop the client or server gracefully #2131
Labels
No labels
In Progress
WIP
WaitingForInfo
bug
doc
duplicate
easy
enhancement
future
help wanted
invalid
lifecycle/stale
need-issue-template
need-usage-help
no plan
proposal
pull-request
question
todo
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/frp#2131
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @hinupurthakur on GitHub (Nov 22, 2021).
Original GitHub issue: https://github.com/fatedier/frp/issues/2670
Describe the feature request
Currently we don't have a command that can stop the frp client (or server) gracefully on a machine
Describe alternatives you've considered
we should have a command like
frpc stop(orfrps stop) to stop the active connections gracefully.Please let me know if this is something we would like to have as a feature, I can help to contribute as well.
Thanks
Affected area
@fatedier commented on GitHub (Nov 23, 2021):
I'm not sure if it's necessary.
Can you describe more about your use case and how to decide when frp service can stop?
Lots of people use frp as port forwarder and their connections will keep alive for a long time.
@hinupurthakur commented on GitHub (Nov 23, 2021):
@fatedier Thanks for the response. I am using it with the application for the http proxy. Once I close the application, I want the frpc to stop (not the server, in my case). Currently I am doing it by the process ID but if we can have an option like
frpc stopbut only if this use case is not too specific for my use.Thank You!
@fatedier commented on GitHub (Nov 24, 2021):
I think it's ok to support graceful shudown only on frpc.
We can add a new api like
/api/stopandfrpc stop --grace-period=10will call this api.PRs on this feature are welcome.
@hinupurthakur commented on GitHub (Nov 29, 2021):
If nobody have yet taken this issue up, I will be happy to work on it.