mirror of
https://github.com/fatedier/frp.git
synced 2026-05-15 08:05:49 -06:00
[GH-ISSUE #2016] frps serves invalid ssl cert even when ssl cert is provided #1602
Labels
No labels
In Progress
WIP
WaitingForInfo
bug
doc
duplicate
easy
enhancement
future
help wanted
invalid
lifecycle/stale
need-issue-template
need-usage-help
no plan
proposal
pull-request
question
todo
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/frp#1602
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @levavakian on GitHub (Sep 29, 2020).
Original GitHub issue: https://github.com/fatedier/frp/issues/2016
What version of frp are you using (./frpc -v or ./frps -v)?
0.34 (latest dev)
What operating system and processor architecture are you using (
go env)?amd64/linux
Configures you used:
Steps to reproduce the issue:
Describe the results you received:
If frpc is not running, then visiting the endpoint results in an error page with
ERR_SSL_PROTOCOL_ERRORand frps gives the log[vhost.go:158] http request for host [***] path [] not foundIf frpc is running, the proxied webpage is served but the ssl certificate is invalid and is shown as a self signed localhost certificate.
Describe the results you expected:
If frpc is not running, I expected the regular frp 404 page with a valid ssl certificate.
If frps is running, I expected the webpage to be served and be secured by the ssl certificate on the frps server.
** Additional questions **
I am assuming that the TLS certificates installed on frps are able to sign the webpages served by the frpc client without any certificates having to be installed on the frpc client. Is that a correct assumption?
@fatedier commented on GitHub (Sep 30, 2020):
The
tls_cert_filein frps is only for TLS connections from frpc, not for vhost-https proxy. We just forward vhost-https connections to frpc by SNI, not decode content.@levavakian commented on GitHub (Sep 30, 2020):
Ah ok, so it is impossible to have frps handle the tls termination on behalf of frpc, while still keeping the communication between frps and frpc tls secured?
@fatedier commented on GitHub (Sep 30, 2020):
Yes.
@mredbishop commented on GitHub (Feb 7, 2025):
My god Chat GPT led me down the garden path before I found this comment 🤦