github-starred/frp

Fork 0

mirror of https://github.com/fatedier/frp.git synced 2026-05-15 08:05:49 -06:00

[GH-ISSUE #1879] Simplify `http2https` plugin design #1486

New issue

Closed

opened 2026-05-05 12:56:22 -06:00 by gitea-mirror · 10 comments

gitea-mirror commented

2026-05-05 12:56:22 -06:00

Owner

Originally created by @septs on GitHub (Jun 22, 2020).
Original GitHub issue: https://github.com/fatedier/frp/issues/1879

original configuration:

[web]
type = http
plugin = http2https
plugin_local_addr = 127.0.0.1:8080

simplify before:

[web]
type = http
local_ip = 127.0.0.1:8080
plugin = sslstrip

rename http2https to sslstrip or strip_https
read local_ip field replace plugin_local_addr

Originally created by @septs on GitHub (Jun 22, 2020). Original GitHub issue: https://github.com/fatedier/frp/issues/1879 original configuration: ```ini [web] type = http plugin = http2https plugin_local_addr = 127.0.0.1:8080 ``` simplify before: ```ini [web] type = http local_ip = 127.0.0.1:8080 plugin = sslstrip ``` 1. rename `http2https` to `sslstrip` or `strip_https` 2. read `local_ip` field replace `plugin_local_addr`

gitea-mirror

2026-05-05 12:56:22 -06:00

closed this issue
added the
todo
label

gitea-mirror commented

2026-05-05 12:56:25 -06:00

Author

Owner

@fatedier commented on GitHub (Jun 24, 2020):

The name is ok, we can use it as alias.

local_ip is conflict with plugin. So we can't reuse this field. fields with plugin_ prefix will be the init parameters for plugins.

@fatedier commented on GitHub (Jun 24, 2020): The name is ok, we can use it as alias. `local_ip` is conflict with `plugin`. So we can't reuse this field. `fields` with `plugin_` prefix will be the init parameters for plugins.

gitea-mirror commented

2026-05-05 12:56:26 -06:00

Author

Owner

@septs commented on GitHub (Jun 24, 2020):

@fatedier remapping local_ip field to plugin_local_addr？

@septs commented on GitHub (Jun 24, 2020): @fatedier remapping `local_ip` field to `plugin_local_addr`？

gitea-mirror commented

2026-05-05 12:56:26 -06:00

Author

Owner

@fatedier commented on GitHub (Jun 24, 2020):

It's not necessary. Plugin can only use fields with plugin_ prefix. It's not the core of frp, but only the plugin configures.

@fatedier commented on GitHub (Jun 24, 2020): It's not necessary. Plugin can only use fields with `plugin_` prefix. It's not the core of frp, but only the plugin configures.

gitea-mirror commented

2026-05-05 12:56:27 -06:00

Author

Owner

@septs commented on GitHub (Jun 24, 2020):

plugin cannot read all fields of ini-section is by design?

@septs commented on GitHub (Jun 24, 2020): plugin cannot read all fields of ini-section is by design?

gitea-mirror commented

2026-05-05 12:56:27 -06:00

Author

Owner

@septs commented on GitHub (Jul 28, 2020):

@fatedier https2http rename to with-tls maybe better

@septs commented on GitHub (Jul 28, 2020): @fatedier `https2http` rename to `with-tls` maybe better

gitea-mirror commented

2026-05-05 12:56:28 -06:00

Author

Owner

@septs commented on GitHub (Jul 28, 2020):

Maybe can provide an alias.

sslstrip, strip-https (external name) mapping to http2https (internal name)
with-tls, with-ssl (external name) mapping to https2http (internal name)

@septs commented on GitHub (Jul 28, 2020): Maybe can provide an alias. `sslstrip`, `strip-https` (external name) mapping to `http2https` (internal name) `with-tls`, `with-ssl` (external name) mapping to `https2http` (internal name)

gitea-mirror commented

2026-05-05 12:56:28 -06:00

Author

Owner

@fatedier commented on GitHub (Jul 28, 2020):

We will keep one plugin name finally.

We can make it compatible between sslstrip and http2https first. Then mark http2https deprecated.

In the specified future release version, we will remove the name http2https.

https2http seems ok now, we may not modify it and gather more advice.

@fatedier commented on GitHub (Jul 28, 2020): We will keep one plugin name finally. We can make it compatible between `sslstrip` and `http2https` first. Then mark `http2https` deprecated. In the specified future release version, we will remove the name `http2https`. `https2http` seems ok now, we may not modify it and gather more advice.

gitea-mirror commented

2026-05-05 12:56:28 -06:00

Author

Owner

@septs commented on GitHub (Jul 28, 2020):

@fatedier

Can you maintain uniform semantics?

plugin_local_addr -> plugin_local_ip

This can be understood as:

plugin_local_ip is local_ip with plugin

@septs commented on GitHub (Jul 28, 2020): @fatedier Can you maintain uniform semantics? `plugin_local_addr` -> `plugin_local_ip` This can be understood as: `plugin_local_ip` is `local_ip` with plugin

gitea-mirror commented

2026-05-05 12:56:29 -06:00

Author

Owner

@fatedier commented on GitHub (Jul 28, 2020):

local_ip should be 127.0.0.1

plugin_local_addr should be 127.0.0.1:80

They are different, address includes ip and port.

@fatedier commented on GitHub (Jul 28, 2020): `local_ip` should be `127.0.0.1` `plugin_local_addr` should be `127.0.0.1:80` They are different, address includes ip and port.

gitea-mirror commented

2026-05-05 12:56:29 -06:00

Author

Owner

@bisansan commented on GitHub (Oct 22, 2020):

sdfsdfdsf

------------------ 原始邮件 ------------------
发件人: "fatedier/frp" <notifications@github.com>;
发送时间: 2020年10月22日(星期四) 上午7:00
收件人: "fatedier/frp"<frp@noreply.github.com>;
抄送: "Subscribed"<subscribed@noreply.github.com>;
主题: Re: [fatedier/frp] Simplify http2https plugin design (#1879)

Closed #1879.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@bisansan commented on GitHub (Oct 22, 2020): sdfsdfdsf ------------------ 原始邮件 ------------------ 发件人: "fatedier/frp" <notifications@github.com>; 发送时间: 2020年10月22日(星期四) 上午7:00 收件人: "fatedier/frp"<frp@noreply.github.com>; 抄送: "Subscribed"<subscribed@noreply.github.com>; 主题: Re: [fatedier/frp] Simplify `http2https` plugin design (#1879) Closed #1879. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.