[GH-ISSUE #1042] [Patch] On including <sys/sysmacros.h> #707

Closed
opened 2026-05-05 06:29:10 -06:00 by gitea-mirror · 3 comments
Owner

Originally created by @hartwork on GitHub (Jan 11, 2017).
Original GitHub issue: https://github.com/netblue30/firejail/issues/1042

Hi!

I noticed that we patch

#include <sys/sysmacros.h>

into the firejail source code in Gentoo, see 8323924482/sys-apps/firejail/files/firejail-0.9.44.2-sysmacros.patch .

Please consider applying that patch upstream. What do you think?
We would no longer have port it forward (as with 0.9.44.4) and could drop the patch count to zero downstream.

Thanks and best, Sebastian

CC: @aidecoe, @vapier

Originally created by @hartwork on GitHub (Jan 11, 2017). Original GitHub issue: https://github.com/netblue30/firejail/issues/1042 Hi! I noticed that we patch ``` #include <sys/sysmacros.h> ``` into the firejail source code in Gentoo, see https://github.com/gentoo/gentoo/blob/8323924482277778d11fb699aa24303338fabdc8/sys-apps/firejail/files/firejail-0.9.44.2-sysmacros.patch . Please consider applying that patch upstream. What do you think? We would no longer have port it forward (as with 0.9.44.4) and could drop the patch count to zero downstream. Thanks and best, Sebastian CC: @aidecoe, @vapier
gitea-mirror 2026-05-05 06:29:11 -06:00
Author
Owner

@netblue30 commented on GitHub (Jan 12, 2017):

I've pushed the patch on all my 3 branches. I've credited it to Mike Frysinger. If this is incorrect, you let me know. Thanks.

<!-- gh-comment-id:272184634 --> @netblue30 commented on GitHub (Jan 12, 2017): I've pushed the patch on all my 3 branches. I've credited it to Mike Frysinger. If this is incorrect, you let me know. Thanks.
Author
Owner

@vapier commented on GitHub (Jan 12, 2017):

hmm, i thought i sent a PR for it, but i guess not. must of been lost in the shuffle.

<!-- gh-comment-id:272201918 --> @vapier commented on GitHub (Jan 12, 2017): hmm, i thought i sent a PR for it, but i guess not. must of been lost in the shuffle.
Author
Owner

@hartwork commented on GitHub (Jan 12, 2017):

Very cool, thank you!

<!-- gh-comment-id:272255428 --> @hartwork commented on GitHub (Jan 12, 2017): Very cool, thank you!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#707
No description provided.