[PR #7068] [MERGED] build: fix discarded const qualifier compiler warnings #6303

New issue

Closed

opened 2026-05-05 10:54:27 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:54:27 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/7068
Author: @kmk3
Created: 2/18/2026
Status: ✅ Merged
Merged: 2/19/2026
Merged by: @kmk3

Base: master ← Head: build-fix-discarded-const-warn

📝 Commits (1)

fb23d31 build: fix discarded const qualifier compiler warnings

📊 Changes

5 files changed (+11 additions, -11 deletions)

View changed files

📝 src/fcopy/main.c (+2 -2)
📝 src/firejail/dbus.c (+2 -2)
📝 src/firejail/env.c (+2 -2)
📝 src/firejail/profile.c (+3 -3)
📝 src/fnet/interface.c (+2 -2)

📄 Description

Fix the following -Wdiscarded-qualifiers warnings:

$ pacman -Q gcc glibc
gcc 15.2.1+r604+g0b99615a8aef-1
glibc 2.43+r5+g856c426a7534-1
$ ./configure >/dev/null && make clean >/dev/null && make >/dev/null
../../src/firejail/dbus.c: In function ‘dbus_check_call_rule’:
../../src/firejail/dbus.c:123:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  123 |         char *name_end = strchr(rule, '=');
      |                          ^~~~~~
../../src/firejail/env.c: In function ‘env_store’:
../../src/firejail/env.c:161:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  161 |         char *ptr = strchr(str, '=');
      |                     ^~~~~~
../../src/firejail/env.c:178:30: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  178 |                 char *ptr2 = strchr(env->name, '=');
      |                              ^~~~~~
../../src/firejail/profile.c: In function ‘profile_read’:
../../src/firejail/profile.c:1753:29: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1753 |                 char *ptr = strstr(base, ".local");
      |                             ^~~~~~
../../src/firejail/profile.c:1769:29: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1769 |                 char *tmp = strrchr(fname, '/');
      |                             ^~~~~~~
../../src/firejail/profile.c:1778:29: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1778 |                 char *tmp = strrchr(fname, '/');
      |                             ^~~~~~~
../../src/fcopy/main.c: In function ‘duplicate_file’:
../../src/fcopy/main.c:433:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  433 |         char *ptr = (arg_follow_link)? strrchr(src, '/'): strrchr(rsrc, '/');
      |                     ^
../../src/fcopy/main.c: In function ‘duplicate_link’:
../../src/fcopy/main.c:457:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  457 |         char *ptr = strrchr(src, '/');
      |                     ^~~~~~~
../../src/fnet/interface.c: In function ‘net_if_ip6’:
../../src/fnet/interface.c:341:18: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  341 |         if ((ptr = strchr(addr6, '/'))) {
      |                  ^

Note: Only the following instances actually modify the pointed-to value:

src/firejail/env.c:178
src/fnet/interface.c:341

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/7068 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 2/18/2026 **Status:** ✅ Merged **Merged:** 2/19/2026 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `build-fix-discarded-const-warn` --- ### 📝 Commits (1) - [`fb23d31`](https://github.com/netblue30/firejail/commit/fb23d311fc320828dfed3672c946f4cdfc3f47c2) build: fix discarded const qualifier compiler warnings ### 📊 Changes **5 files changed** (+11 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/fcopy/main.c` (+2 -2) 📝 `src/firejail/dbus.c` (+2 -2) 📝 `src/firejail/env.c` (+2 -2) 📝 `src/firejail/profile.c` (+3 -3) 📝 `src/fnet/interface.c` (+2 -2) </details> ### 📄 Description Fix the following `-Wdiscarded-qualifiers` warnings: $ pacman -Q gcc glibc gcc 15.2.1+r604+g0b99615a8aef-1 glibc 2.43+r5+g856c426a7534-1 $ ./configure >/dev/null && make clean >/dev/null && make >/dev/null ../../src/firejail/dbus.c: In function ‘dbus_check_call_rule’: ../../src/firejail/dbus.c:123:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 123 | char *name_end = strchr(rule, '='); | ^~~~~~ ../../src/firejail/env.c: In function ‘env_store’: ../../src/firejail/env.c:161:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 161 | char *ptr = strchr(str, '='); | ^~~~~~ ../../src/firejail/env.c:178:30: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 178 | char *ptr2 = strchr(env->name, '='); | ^~~~~~ ../../src/firejail/profile.c: In function ‘profile_read’: ../../src/firejail/profile.c:1753:29: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 1753 | char *ptr = strstr(base, ".local"); | ^~~~~~ ../../src/firejail/profile.c:1769:29: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 1769 | char *tmp = strrchr(fname, '/'); | ^~~~~~~ ../../src/firejail/profile.c:1778:29: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 1778 | char *tmp = strrchr(fname, '/'); | ^~~~~~~ ../../src/fcopy/main.c: In function ‘duplicate_file’: ../../src/fcopy/main.c:433:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 433 | char *ptr = (arg_follow_link)? strrchr(src, '/'): strrchr(rsrc, '/'); | ^ ../../src/fcopy/main.c: In function ‘duplicate_link’: ../../src/fcopy/main.c:457:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 457 | char *ptr = strrchr(src, '/'); | ^~~~~~~ ../../src/fnet/interface.c: In function ‘net_if_ip6’: ../../src/fnet/interface.c:341:18: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 341 | if ((ptr = strchr(addr6, '/'))) { | ^ Note: Only the following instances actually modify the pointed-to value: * src/firejail/env.c:178 * src/fnet/interface.c:341 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:54:27 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6303

No description provided.

Rows
Columns