[PR #6970] [CLOSED] bugfix: make checkcfg init/cfg vars global #6255

New issue

Closed

opened 2026-05-05 10:53:34 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:53:34 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6970
Author: @kmk3
Created: 11/21/2025
Status: ❌ Closed

Base: master ← Head: fix-make-checkcfg-vars-global

📝 Commits (2)

a2283e3 checkcfg.c: rename "initialized" var to "firejail_config_init"
f246be1 bugfix: make checkcfg init/cfg vars global

📊 Changes

2 files changed (+7 additions, -5 deletions)

View changed files

📝 src/firejail/checkcfg.c (+5 -5)
📝 src/firejail/firejail.h (+2 -0)

📄 Description

Instead of them being local to the translation unit.

This should ensure that firejail.config is not read more than once (as
is intended by the code), especially after options like private-etc
are applied (which could render the file inaccessible when calling
checkcfg()).

Related commits:

8bff773d6 ("add symlink resolution for home directories", 2019-07-09)
/ issue #2877
d32509945 ("rewrite/partial revert of
8bff773d6a", 2019-08-09)
/ issue #2877
d1aeeb4fa ("feature: add arg-max-count and arg-max-len options to
firejail.config (#6878)", 2025-10-30)

Relates to #2877 #6966.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6970 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 11/21/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-make-checkcfg-vars-global` --- ### 📝 Commits (2) - [`a2283e3`](https://github.com/netblue30/firejail/commit/a2283e3b8b6967830e3ec7fd319b535cbb15ee33) checkcfg.c: rename "initialized" var to "firejail_config_init" - [`f246be1`](https://github.com/netblue30/firejail/commit/f246be1d586a700bd5fe9af68b1df2730ca82ed4) bugfix: make checkcfg init/cfg vars global ### 📊 Changes **2 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/checkcfg.c` (+5 -5) 📝 `src/firejail/firejail.h` (+2 -0) </details> ### 📄 Description Instead of them being local to the translation unit. This should ensure that firejail.config is not read more than once (as is intended by the code), especially after options like `private-etc` are applied (which could render the file inaccessible when calling `checkcfg()`). Related commits: * 8bff773d6 ("add symlink resolution for home directories", 2019-07-09) / issue #2877 * d32509945 ("rewrite/partial revert of 8bff773d6a7bf70c97b3d5b751df9ec0dd6c8b5d", 2019-08-09) / issue #2877 * d1aeeb4fa ("feature: add arg-max-count and arg-max-len options to firejail.config (#6878)", 2025-10-30) Relates to #2877 #6966. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:53:34 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6255

No description provided.

Rows
Columns