[PR #6971] [MERGED] bugfix: do sandbox check before checkcfg() #6254

Closed
opened 2026-05-05 10:53:34 -06:00 by gitea-mirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6971
Author: @kmk3
Created: 11/22/2025
Status: Merged
Merged: 12/4/2025
Merged by: @netblue30

Base: masterHead: fix-sandbox-check-before-checkcfg


📝 Commits (1)

  • 768b2a2 bugfix: do sandbox check before checkcfg()

📊 Changes

1 file changed (+30 additions, -24 deletions)

View changed files

📝 src/firejail/main.c (+30 -24)

📄 Description

The check for an existing sandbox (and running run_no_sandbox() if
applicable) must be done before calling checkcfg(), since if
private-etc is already in effect, running firejail again will abort at
checkcfg(), as /etc/firejail/firejail.config will not be accessible
(see #6966).

This is a follow-up to #6969.

Relates to #2877 #6878 #6951 #6966.

Kind of relates to #6592.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6971 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 11/22/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@netblue30](https://github.com/netblue30) **Base:** `master` ← **Head:** `fix-sandbox-check-before-checkcfg` --- ### 📝 Commits (1) - [`768b2a2`](https://github.com/netblue30/firejail/commit/768b2a2e640226b1ac12ef6be77da98f0c048702) bugfix: do sandbox check before checkcfg() ### 📊 Changes **1 file changed** (+30 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/firejail/main.c` (+30 -24) </details> ### 📄 Description The check for an existing sandbox (and running `run_no_sandbox()` if applicable) must be done before calling `checkcfg()`, since if `private-etc` is already in effect, running firejail again will abort at `checkcfg()`, as /etc/firejail/firejail.config will not be accessible (see #6966). This is a follow-up to #6969. Relates to #2877 #6878 #6951 #6966. Kind of relates to #6592. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
gitea-mirror 2026-05-05 10:53:34 -06:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6254
No description provided.