[PR #6885] [MERGED] profiles: organize blacklist sections as per profile.template #6217

New issue

Closed

opened 2026-05-05 10:52:55 -06:00 by gitea-mirror · 0 comments

gitea-mirror commented

2026-05-05 10:52:55 -06:00

Owner

📋 Pull Request Information

Original PR: https://github.com/netblue30/firejail/pull/6885
Author: @kmk3
Created: 9/1/2025
Status: ✅ Merged
Merged: 9/4/2025
Merged by: @kmk3

Base: master ← Head: profiles-organize-blacklists

📝 Commits (3)

872b055 profiles: rtv: move rtv-addons comment to the top
a45e201 profiles: curl/wget: move nvm comments to the top
da5dd4b profiles: organize blacklist sections as per profile.template

📊 Changes

49 files changed (+112 additions, -107 deletions)

View changed files

📝 etc/profile-a-l/agetpkg.profile (+2 -2)
📝 etc/profile-a-l/checkbashisms.profile (+2 -2)
📝 etc/profile-a-l/curl.profile (+4 -4)
📝 etc/profile-a-l/deadlink.profile (+3 -3)
📝 etc/profile-a-l/devilspie.profile (+2 -2)
📝 etc/profile-a-l/enchant.profile (+2 -2)
📝 etc/profile-a-l/evince.profile (+2 -1)
📝 etc/profile-a-l/exiftool.profile (+2 -2)
📝 etc/profile-a-l/gconf.profile (+2 -2)
📝 etc/profile-a-l/gist.profile (+2 -2)
📝 etc/profile-a-l/gnome-boxes.profile (+2 -2)
📝 etc/profile-a-l/googler-common.profile (+2 -2)
📝 etc/profile-a-l/green-recoder.profile (+2 -2)
📝 etc/profile-a-l/hashcat.profile (+2 -2)
📝 etc/profile-a-l/highlight.profile (+2 -2)
📝 etc/profile-a-l/host.profile (+2 -1)
📝 etc/profile-a-l/img2txt.profile (+2 -2)
📝 etc/profile-a-l/koreader.profile (+2 -2)
📝 etc/profile-a-l/less.profile (+2 -2)
📝 etc/profile-a-l/localsend_app.profile (+2 -2)

...and 29 more files

📄 Description

On each profile, ensure that the blacklist section is right above the
include disable section.

See etc/templates/profile.template.

Misc: This appears to affect about a third of the profiles that contain
blacklist entries:

$ git grep -El '^#?blacklist ' -- etc/profile* | wc -l
158
$ git diff --name-only f1381b342 | wc -l
49

Kind of relates to commit 04efbb276 ("profiles: replace x11 socket
blacklist with disable-X11.inc", 2024-03-22) / PR #6286.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/netblue30/firejail/pull/6885 **Author:** [@kmk3](https://github.com/kmk3) **Created:** 9/1/2025 **Status:** ✅ Merged **Merged:** 9/4/2025 **Merged by:** [@kmk3](https://github.com/kmk3) **Base:** `master` ← **Head:** `profiles-organize-blacklists` --- ### 📝 Commits (3) - [`872b055`](https://github.com/netblue30/firejail/commit/872b0551f9fc811e222e2a8d1e70fa0129fc8bae) profiles: rtv: move rtv-addons comment to the top - [`a45e201`](https://github.com/netblue30/firejail/commit/a45e2016fe7678ef02c0b2a3cfbc2e9f8f04a475) profiles: curl/wget: move nvm comments to the top - [`da5dd4b`](https://github.com/netblue30/firejail/commit/da5dd4bc0c151695037d513d0a0f01fc2d4c77f8) profiles: organize blacklist sections as per profile.template ### 📊 Changes **49 files changed** (+112 additions, -107 deletions) <details> <summary>View changed files</summary> 📝 `etc/profile-a-l/agetpkg.profile` (+2 -2) 📝 `etc/profile-a-l/checkbashisms.profile` (+2 -2) 📝 `etc/profile-a-l/curl.profile` (+4 -4) 📝 `etc/profile-a-l/deadlink.profile` (+3 -3) 📝 `etc/profile-a-l/devilspie.profile` (+2 -2) 📝 `etc/profile-a-l/enchant.profile` (+2 -2) 📝 `etc/profile-a-l/evince.profile` (+2 -1) 📝 `etc/profile-a-l/exiftool.profile` (+2 -2) 📝 `etc/profile-a-l/gconf.profile` (+2 -2) 📝 `etc/profile-a-l/gist.profile` (+2 -2) 📝 `etc/profile-a-l/gnome-boxes.profile` (+2 -2) 📝 `etc/profile-a-l/googler-common.profile` (+2 -2) 📝 `etc/profile-a-l/green-recoder.profile` (+2 -2) 📝 `etc/profile-a-l/hashcat.profile` (+2 -2) 📝 `etc/profile-a-l/highlight.profile` (+2 -2) 📝 `etc/profile-a-l/host.profile` (+2 -1) 📝 `etc/profile-a-l/img2txt.profile` (+2 -2) 📝 `etc/profile-a-l/koreader.profile` (+2 -2) 📝 `etc/profile-a-l/less.profile` (+2 -2) 📝 `etc/profile-a-l/localsend_app.profile` (+2 -2) _...and 29 more files_ </details> ### 📄 Description On each profile, ensure that the `blacklist` section is right above the `include disable` section. See etc/templates/profile.template. Misc: This appears to affect about a third of the profiles that contain `blacklist` entries: $ git grep -El '^#?blacklist ' -- etc/profile* | wc -l 158 $ git diff --name-only f1381b342 | wc -l 49 Kind of relates to commit 04efbb276 ("profiles: replace x11 socket blacklist with disable-X11.inc", 2024-03-22) / PR #6286. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

gitea-mirror

2026-05-05 10:52:55 -06:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/firejail#6217

No description provided.

Rows
Columns